[GitHub] [hudi] danny0405 commented on a diff in pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8127:
URL: https://github.com/apache/hudi/pull/8127#discussion_r1129246272


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -287,13 +287,6 @@ private Map<String, Option<HoodieRecord<HoodieMetadataPayload>>> readLogRecords(
                 .map(record -> Pair.of(record.getRecordKey(), Option.of(record)))
                 .collect(Collectors.toList());
 
-    // Second, back-fill keys not present in the log-blocks (such that map holds
-    // a record for every key being looked up)
-    List<String> missingKeys = CollectionUtils.diff(keys, logRecords.keySet());
-    for (String key : missingKeys) {

Review Comment:
   This is a totally useless code because the invoker already handles this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org