You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "wernerdv (via GitHub)" <gi...@apache.org> on 2025/07/14 12:58:08 UTC
[PR] IGNITE-25882 Remove Serializable interface from Message [ignite]
wernerdv opened a new pull request, #12185:
URL: https://github.com/apache/ignite/pull/12185
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25882 Remove Serializable interface from Message [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12185:
URL: https://github.com/apache/ignite/pull/12185#issuecomment-3083945194
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12185) **Quality Gate failed**
Failed conditions
 [11 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12185) (required ≤ 1)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12185)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25882 Remove Serializable interface from Message [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim merged PR #12185:
URL: https://github.com/apache/ignite/pull/12185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25882 Remove Serializable interface from Message [ignite]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #12185:
URL: https://github.com/apache/ignite/pull/12185#discussion_r2210416276
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/messages/StatisticsColumnData.java:
##########
@@ -25,7 +26,7 @@
/**
* Statistics by column (or by set of columns, if they collected together)
*/
-public class StatisticsColumnData implements Message {
+public class StatisticsColumnData implements Message, Serializable {
Review Comment:
StatisticsObjectData class is marshaled using JdkMarshaller and contains field `private Map<String, StatisticsColumnData> data`.
If you remove Serializable interface from StatisticsColumnData, StatisticsCommandDdlIntegrationTest will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25882 Remove Serializable interface from Message [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #12185:
URL: https://github.com/apache/ignite/pull/12185#discussion_r2209543601
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheInvokeDirectResult.java:
##########
@@ -34,9 +34,6 @@
*
*/
public class CacheInvokeDirectResult implements Message {
Review Comment:
This class contains transient field. Let's keep Serializable for a while.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/encryption/GridEncryptionManager.java:
##########
@@ -1307,7 +1307,7 @@ private void writeGroupKeysToMetaStore(int grpId, List<GroupKeyEncrypted> keys)
ctx.cache().context().database().checkpointReadLock();
try {
- metaStorage.write(ENCRYPTION_KEYS_PREFIX + grpId, (Serializable)keys);
Review Comment:
You must not change API of the MetaStorage
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsPersistenceStoreImpl.java:
##########
@@ -630,7 +630,7 @@ private boolean checkMetastore(String msg, Object... args) {
* @param obj Object to write.
* @throws IgniteCheckedException Throws in case of errors.
*/
- private void writeMeta(String key, Serializable obj) throws IgniteCheckedException {
+ private void writeMeta(String key, Object obj) throws IgniteCheckedException {
Review Comment:
same
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
@@ -235,7 +235,7 @@
* @see IgniteMessaging
* @see TransmissionHandler
*/
-public class GridIoManager extends GridManagerAdapter<CommunicationSpi<Serializable>> {
+public class GridIoManager extends GridManagerAdapter<CommunicationSpi<Message>> {
Review Comment:
GridIoManager is a wrapper over interface CommunicationSpi<T>. We can't use Message here, if another CommunicationSpi is in use.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/metastorage/MetaStorage.java:
##########
@@ -409,7 +409,7 @@ private void applyCallback(
}
/** {@inheritDoc} */
- @Override public void write(@NotNull String key, @NotNull Serializable val) throws IgniteCheckedException {
+ @Override public void write(@NotNull String key, @NotNull Object val) throws IgniteCheckedException {
Review Comment:
You must not change API for the MetaStorage
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheSqlQuery.java:
##########
@@ -34,9 +34,6 @@
* Query.
*/
public class GridCacheSqlQuery implements Message {
Review Comment:
Contains transient fields. Let's keep it Serializable for a while
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/metastorage/persistence/ReadWriteMetaStorageMock.java:
##########
@@ -33,7 +33,7 @@ public class ReadWriteMetaStorageMock implements ReadWriteMetastorage {
public final Map<String, byte[]> cache = new ConcurrentSkipListMap<>();
/** {@inheritDoc} */
- @Override public void write(@NotNull String key, @NotNull Serializable val) throws IgniteCheckedException {
+ @Override public void write(@NotNull String key, @NotNull Object val) throws IgniteCheckedException {
Review Comment:
same
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/messages/StatisticsColumnData.java:
##########
@@ -25,7 +26,7 @@
/**
* Statistics by column (or by set of columns, if they collected together)
*/
-public class StatisticsColumnData implements Message {
+public class StatisticsColumnData implements Message, Serializable {
Review Comment:
Why Serializable?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/metastorage/ReadWriteMetastorage.java:
##########
@@ -25,7 +24,7 @@
*/
public interface ReadWriteMetastorage extends ReadOnlyMetastorage {
/** */
- public void write(@NotNull String key, @NotNull Serializable val) throws IgniteCheckedException;
+ public void write(@NotNull String key, @NotNull Object val) throws IgniteCheckedException;
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org