[jira] [Commented] (MESOS-3169) FrameworkInfo should only be updated if the re-registration is valid

["Klaus Ma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663066#comment-14663066 ] 

Klaus Ma commented on MESOS-3169:
---------------------------------

But what's the error handling if failed to update framework info? Just log ERROR/WARN message and ignore it?

> FrameworkInfo should only be updated if the re-registration is valid
> --------------------------------------------------------------------
>
>                 Key: MESOS-3169
>                 URL: https://issues.apache.org/jira/browse/MESOS-3169
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.23.0
>            Reporter: Joris Van Remoortere
>              Labels: framework, master, mesosphere, tech-debt
>
> See Ben Mahler's comment in https://reviews.apache.org/r/32961/
> FrameworkInfo should not be updated if the re-registration is invalid. This can happen in a few cases under the branching logic, so this requires some refactoring.
> Notice that a {code}FrameworkErrorMessage{code} can be generated  both inside {code}else if (from != framework->pid){code} as well as from inside {code}failoverFramework(framework, from);{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)