You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cl...@apache.org on 2011/10/13 18:47:43 UTC

svn commit: r1182974 - in /felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo: Extender.java util/Property.java

Author: clement
Date: Thu Oct 13 16:47:42 2011
New Revision: 1182974

URL: http://svn.apache.org/viewvc?rev=1182974&view=rev
Log:
Fixed Felix-3155
Applied the patch from German Vega. 

Removed wrong comment in Property.java

Modified:
    felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/Extender.java
    felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/util/Property.java

Modified: felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/Extender.java
URL: http://svn.apache.org/viewvc/felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/Extender.java?rev=1182974&r1=1182973&r2=1182974&view=diff
==============================================================================
--- felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/Extender.java (original)
+++ felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/Extender.java Thu Oct 13 16:47:42 2011
@@ -253,7 +253,14 @@ public class Extender implements Synchro
         String[] arr = ParseUtils.split(header, ",");
         for (int i = 0; arr != null && i < arr.length; i++) {
             String[] arr2 = ParseUtils.split(arr[i], ":");
-            String type = arr2[0];
+            
+            /*
+             * Get the fully qualified type name.
+             * type = [namespace] name  
+             */
+            String[] nameparts = ParseUtils.split(arr2[0].trim(), " \t");
+            String type = nameparts.length == 1 ? nameparts[0] : nameparts[0]+":"+nameparts[1];
+            
             Class clazz;
             try {
                 clazz = bundle.loadClass(arr2[1]);
@@ -288,7 +295,8 @@ public class Extender implements Synchro
         ManifestMetadataParser parser = new ManifestMetadataParser();
         parser.parseHeader(components);
 
-        Element[] metadata = parser.getComponentsMetadata(); // Get the component type declaration
+        // Get the component type declaration
+        Element[] metadata = parser.getComponentsMetadata();
         for (int i = 0; i < metadata.length; i++) {
             createAbstractFactory(bundle, metadata[i]);
         }
@@ -465,9 +473,13 @@ public class Extender implements Synchro
     private void createAbstractFactory(Bundle bundle, Element metadata) {
         ManagedAbstractFactoryType factoryType = null;
         // First, look for factory-type (component, handler, composite ...)
+        
+        // TODO : Should Element.getQualifiedName() be public ?
+        String typeName = metadata.getNameSpace() == null ? metadata.getName() : metadata.getNameSpace()+":"+metadata.getName();
+        
         for (int i = 0; i < m_factoryTypes.size(); i++) {
             ManagedAbstractFactoryType type = (ManagedAbstractFactoryType) m_factoryTypes.get(i);
-            if (type.m_type.equals(metadata.getName())) {
+            if (type.m_type.equals(typeName)) {
                 factoryType = type;
                 break;
             }
@@ -475,8 +487,8 @@ public class Extender implements Synchro
 
         // If not found, return. It will wait for a new component type factory.
         if (factoryType == null) {
-            m_logger.log(Logger.WARNING, "Type of component not available: " + metadata.getName());
-            m_unboundTypes.add(new UnboundComponentType(metadata.getName(), metadata, bundle));
+            m_logger.log(Logger.WARNING, "Type of component not available: " + typeName);
+            m_unboundTypes.add(new UnboundComponentType(typeName, metadata, bundle));
             return;
         }
 

Modified: felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/util/Property.java
URL: http://svn.apache.org/viewvc/felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/util/Property.java?rev=1182974&r1=1182973&r2=1182974&view=diff
==============================================================================
--- felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/util/Property.java (original)
+++ felix/trunk/ipojo/core/src/main/java/org/apache/felix/ipojo/util/Property.java Thu Oct 13 16:47:42 2011
@@ -543,7 +543,6 @@ public class Property implements FieldIn
      * Invokes the setter method on the given pojo object.
      * If no specified pojo object, it calls on each created pojo object.
      * @param instance the created object (could be <code>null</code>)
-     * @see org.apache.felix.ipojo.Handler#onCreation(java.lang.Object)
      */
     public synchronized void invoke(Object instance) {
         if (m_invoked) {