You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "astefanutti (via GitHub)" <gi...@apache.org> on 2023/03/13 08:35:56 UTC

[GitHub] [camel-k] astefanutti commented on a diff in pull request #4120: fix(knative): Integration in error state when knative SinkBinding mode=inclusion

astefanutti commented on code in PR #4120:
URL: https://github.com/apache/camel-k/pull/4120#discussion_r1133590182


##########
config/rbac/operator-role.yaml:
##########
@@ -71,6 +71,7 @@ rules:
   - configmaps
   - secrets
   - serviceaccounts
+  - namespaces

Review Comment:
   It doesn't seem like a best practice to grant all verbs on `namespaces` resources, especially `delete` and `deletecollection`.  Could this be refined to the minimal set of verbs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org