[jira] [Commented] (FINERACT-972) Ensure Cargo Tomcat is not left running after build

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108509#comment-17108509 ] 

Michael Vorburger commented on FINERACT-972:
--------------------------------------------

This is great! I had been wondering why Tomcat sometimes didn't shut down as expected.... now I know!  :D

Thanks for having spotted and fixed this.

> Ensure Cargo Tomcat is not left running after build
> ---------------------------------------------------
>
>                 Key: FINERACT-972
>                 URL: https://issues.apache.org/jira/browse/FINERACT-972
>             Project: Apache Fineract
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.4.0
>            Reporter: Petri Tuomola
>            Assignee: Petri Tuomola
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> Currently we start Tomcat for integration testing *before* we build the integration tests.
> If integration test build fails then we do not automatically shut down Tomcat, but leave it running under Gradle daemon. 
> This means the next build will fail as it will try to start Tomcat again, but find that the port is already in use.
> We should postpone starting Tomcat for integration test until after all the tests have been successfully built, and we should also ensure we always shut down the Tomcat instance at end of script. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)