You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/12 20:21:45 UTC
[GitHub] [geode] jinmeiliao opened a new pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
jinmeiliao opened a new pull request #6985:
URL: https://github.com/apache/geode/pull/6985
* add more tests for durable clients
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao commented on a change in pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on a change in pull request #6985:
URL: https://github.com/apache/geode/pull/6985#discussion_r727590335
##########
File path: geode-core/src/upgradeTest/java/org/apache/geode/security/AuthExpirationDUnitTest.java
##########
@@ -513,52 +560,67 @@ public void registeredInterestWithFailedReAuth() throws Exception {
clientVM.invoke(() -> {
IgnoredException.addIgnoredException(AuthenticationFailedException.class);
Region<Object, Object> clientRegion = ClusterStartupRule.getClientCache().getRegion("region");
- await().during(2, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
+ await().during(10, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
Review comment:
It makes sure the condition holds for 10 seconds. I want to wait a little longer than 2 seconds to make sure the client won't receive all the messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mhansonp commented on a change in pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
Posted by GitBox <gi...@apache.org>.
mhansonp commented on a change in pull request #6985:
URL: https://github.com/apache/geode/pull/6985#discussion_r727588018
##########
File path: geode-core/src/upgradeTest/java/org/apache/geode/security/AuthExpirationDUnitTest.java
##########
@@ -513,52 +560,67 @@ public void registeredInterestWithFailedReAuth() throws Exception {
clientVM.invoke(() -> {
IgnoredException.addIgnoredException(AuthenticationFailedException.class);
Region<Object, Object> clientRegion = ClusterStartupRule.getClientCache().getRegion("region");
- await().during(2, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
+ await().during(10, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
Review comment:
Does this await need to be 10 or can it be the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao merged pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
Posted by GitBox <gi...@apache.org>.
jinmeiliao merged pull request #6985:
URL: https://github.com/apache/geode/pull/6985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mhansonp commented on a change in pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
Posted by GitBox <gi...@apache.org>.
mhansonp commented on a change in pull request #6985:
URL: https://github.com/apache/geode/pull/6985#discussion_r727588018
##########
File path: geode-core/src/upgradeTest/java/org/apache/geode/security/AuthExpirationDUnitTest.java
##########
@@ -513,52 +560,67 @@ public void registeredInterestWithFailedReAuth() throws Exception {
clientVM.invoke(() -> {
IgnoredException.addIgnoredException(AuthenticationFailedException.class);
Region<Object, Object> clientRegion = ClusterStartupRule.getClientCache().getRegion("region");
- await().during(2, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
+ await().during(10, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
Review comment:
Does this await need to be 10 or can it be the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao merged pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
Posted by GitBox <gi...@apache.org>.
jinmeiliao merged pull request #6985:
URL: https://github.com/apache/geode/pull/6985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao commented on a change in pull request #6985: GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations for re-auth
Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on a change in pull request #6985:
URL: https://github.com/apache/geode/pull/6985#discussion_r727590335
##########
File path: geode-core/src/upgradeTest/java/org/apache/geode/security/AuthExpirationDUnitTest.java
##########
@@ -513,52 +560,67 @@ public void registeredInterestWithFailedReAuth() throws Exception {
clientVM.invoke(() -> {
IgnoredException.addIgnoredException(AuthenticationFailedException.class);
Region<Object, Object> clientRegion = ClusterStartupRule.getClientCache().getRegion("region");
- await().during(2, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
+ await().during(10, TimeUnit.SECONDS).untilAsserted(() -> assertThat(clientRegion).isEmpty());
Review comment:
It makes sure the condition holds for 10 seconds. I want to wait a little longer than 2 seconds to make sure the client won't receive all the messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org