[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9312: fix: grpc_set_header Te trailers

["monkeyDluffy6017 (via GitHub)" <gi...@apache.org>]

monkeyDluffy6017 commented on code in PR #9312:
URL: https://github.com/apache/apisix/pull/9312#discussion_r1170777547


##########
apisix/cli/ngx_tpl.lua:
##########
@@ -766,6 +766,7 @@ http {
             grpc_set_header   "Host" $upstream_host;
             {% end %}
             grpc_set_header   Content-Type application/grpc;
+            grpc_set_header   Te trailers;

Review Comment:
   The `trailers` is needed in grpc.
   1. status (grpc-status) is sent as a trailing header after the content is sent. 
   2. support streaming use cases
   So the request header `Te: trailers` is needed in grpc.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org