You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Siddharth Seth (JIRA)" <ji...@apache.org> on 2014/10/15 20:35:34 UTC
[jira] [Comment Edited] (TEZ-1479) Disambiguate between
ShuffleInputEventHandler and ShuffleInputEventHandlerImpl (which are not
related)
[ https://issues.apache.org/jira/browse/TEZ-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172738#comment-14172738 ]
Siddharth Seth edited comment on TEZ-1479 at 10/15/14 6:35 PM:
---------------------------------------------------------------
Have made the following changes in the patch.
- Renamed Fetcher / ShuffleInputEventHandler used by OrderedMerged Input with a "OrderedMerged" suffix.
- Moved all files related to OrderedMergedShuffle into package "org.apache.tez.runtime.library.common.shuffle.orderedgrouped"
- Moved all files related to the other Shuffle to "org.apache.tez.runtime.library.common.shuffle" and "org.apache.tez.runtime.library.common.shuffle.impl"
[~gopalv] - could you please review this. Would appreciate a quick look since this touches a lot of files.
The patch was generated using diff -M to reflect the renames. Applies on top of TEZ-1637. I'll commit that shortly to make this easier to look at.
This becomes more relevant after the log verbosity patch which doesn't log the entier package name any longer.
was (Author: sseth):
Have made the following changes in the patch.
- Renamed Fetcher / ShuffleInputEventHandler used by OrderedMerged Input with a "OrderedMerged" suffix.
- Moved all files related to OrderedMergedShuffle into package "org.apache.tez.runtime.library.common.shuffle.orderedgrouped"
- Moved all files related to the other Shuffle to "org.apache.tez.runtime.library.common.shuffle" and "org.apache.tez.runtime.library.common.shuffle.impl"
[~gopalv] - could you please review this. Would appreciate a quick look since this touches a lot of files.
The patch was generated using diff -M to reflect the renames. Applies on top of TEZ-1637. I'll commit that shortly to make this easier to look at.
> Disambiguate between ShuffleInputEventHandler and ShuffleInputEventHandlerImpl (which are not related)
> ------------------------------------------------------------------------------------------------------
>
> Key: TEZ-1479
> URL: https://issues.apache.org/jira/browse/TEZ-1479
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Gopal V
> Assignee: Siddharth Seth
> Attachments: TEZ-1479.1.txt
>
>
> common.shuffle.impl.ShuffleInputEventHandler is not related to shuffle.common.impl.ShuffleInputEventHandlerImpl
> This is extremely confusing and needs refactoring internally to be readable.
> Same applies to common.shuffle.impl.Fetcher and shuffle.common.Fetcher classes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)