You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/12/10 15:33:37 UTC
[GitHub] zeppelin pull request #1744: Better output of JDBC Interpreter.
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1744
Better output of JDBC Interpreter.
### What is this PR for?
Currently, the output format of the JDBC Interpreter is the table format with all the results except EXPLAIN statement, It is better for the user experience to output only the result of the SELECT statement in table format.
This PR fixes the above issue and did some code refactoring.
Tested on mysql and aws athena.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1784
### How should this be tested?
- before
<img width="1132" alt="2016-12-11 12 30 54" src="https://cloud.githubusercontent.com/assets/3348133/21074311/3bb25bd0-bf39-11e6-8cc2-c72af742c6fe.png">
<img width="1105" alt="2016-12-11 12 32 47" src="https://cloud.githubusercontent.com/assets/3348133/21074320/61b2cdd8-bf39-11e6-8be2-b02eb48b32a7.png">
- after
<img width="1147" alt="2016-12-11 12 15 43" src="https://cloud.githubusercontent.com/assets/3348133/21074296/e349e3e6-bf38-11e6-96c2-fa7e92265e94.png">
<img width="1097" alt="2016-12-11 12 21 06" src="https://cloud.githubusercontent.com/assets/3348133/21074297/e888130a-bf38-11e6-963e-d9fbe7eafb0f.png">
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1784
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1744
----
commit 884113cfe9868bc2cd17fd1601cad0b67e155df8
Author: astroshim <hs...@zepl.com>
Date: 2016-12-10T15:09:15Z
change output type of JDBC Interpreter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1744
Thank you @Leemoonsoo and @bzz help to review.
CI failure is not irrelevant to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1744
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1744
Looks great to me, modulo minor issue above.
Also, in my experience if CI failure reason is summarised and posted here by PR author - it makes merging/reviewing process much faster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1744
Merge to master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1744: Better output of JDBC Interpreter.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---