You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Siyao Meng (Jira)" <ji...@apache.org> on 2021/11/11 00:45:00 UTC
[jira] [Updated] (HDDS-5969) TestRootedOzoneFileSystem
parameterized test is not initialized properly
[ https://issues.apache.org/jira/browse/HDDS-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siyao Meng updated HDDS-5969:
-----------------------------
Description:
While working on HDDS-5891, I found that the paramerized test is not actually properly initialized for EACH set of parameter. Which means the tests run maybe not actually use the intended parameters.
See my comment in the commit for [PR #2814|https://github.com/apache/ozone/pull/2814] (for HDDS-5891) for a detailed description of the issue: https://github.com/smengcl/hadoop-ozone/commit/a90f1cd8c0a7565c8e9d2e40a478b40fc67e4bab#diff-334f953cdb88a5c0d11063f5d9e2dade4f4fb03a90245611fa87329ae9ebe28cR1540-R1551
I will leave a patch diff (based on [PR #2814|https://github.com/apache/ozone/pull/2814]) here for now. When HDDS-5891 is merged I will post a PR for this.
Pinging [~adoroszlai] and [~hanishakoneru] since you've made changes to the {{@Parameterized.Parameters}} before, and I need your input on whether to just disable the 3 failing tests when {{ozone.om.enable.filesystem.paths}} is enabled (they are failing because the parameterized test is properly initialized with the patch now), or fix these tests in some way.
A list of failing tests when {{ozone.om.enable.filesystem.paths}} is enabled:
{code:java|title=TestRootedOzoneFileSystem}
testDeleteCreatesFakeParentDir
testMkdirOnNonExistentVolumeBucketDir
testListStatusRootAndVolumeContinuation
{code}
I have fixed {{testListStatusRootAndVolumeNonRecursive}} when it was failing when ACL is enabled (due to volume LIST ACL permission) myself.
was:
While working on HDDS-5891, I found that the paramerized test is not actually properly initialized for EACH set of parameter. Which means the tests run maybe not actually use the intended parameters.
See my comment in the commit for [PR #2814|https://github.com/apache/ozone/pull/2814] (for HDDS-5891) for a detailed description of the issue: https://github.com/smengcl/hadoop-ozone/commit/a90f1cd8c0a7565c8e9d2e40a478b40fc67e4bab#diff-334f953cdb88a5c0d11063f5d9e2dade4f4fb03a90245611fa87329ae9ebe28cR1540-R1551
I will leave a patch diff (based on [PR #2814|https://github.com/apache/ozone/pull/2814]) here for now. When HDDS-5891 is merged I will post a PR for this.
Pinging [~adoroszlai] and [~hanishakoneru] since you've made changes to the {{@Parameterized.Parameters}} before, and I need your input on whether to just disable the 3 failing tests when {{ozone.om.enable.filesystem.paths}} is enabled (they are failing because the parameterized test is properly initialized with the patch now), or fix these tests in some way.
A list of failing tests when {{ozone.om.enable.filesystem.paths}} is enabled:
{code:java|title=TestRootedOzoneFileSystem}
testDeleteCreatesFakeParentDir
testMkdirOnNonExistentVolumeBucketDir
testListStatusRootAndVolumeContinuation
{code}
> TestRootedOzoneFileSystem parameterized test is not initialized properly
> ------------------------------------------------------------------------
>
> Key: HDDS-5969
> URL: https://issues.apache.org/jira/browse/HDDS-5969
> Project: Apache Ozone
> Issue Type: Bug
> Components: test
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
>
> While working on HDDS-5891, I found that the paramerized test is not actually properly initialized for EACH set of parameter. Which means the tests run maybe not actually use the intended parameters.
> See my comment in the commit for [PR #2814|https://github.com/apache/ozone/pull/2814] (for HDDS-5891) for a detailed description of the issue: https://github.com/smengcl/hadoop-ozone/commit/a90f1cd8c0a7565c8e9d2e40a478b40fc67e4bab#diff-334f953cdb88a5c0d11063f5d9e2dade4f4fb03a90245611fa87329ae9ebe28cR1540-R1551
> I will leave a patch diff (based on [PR #2814|https://github.com/apache/ozone/pull/2814]) here for now. When HDDS-5891 is merged I will post a PR for this.
> Pinging [~adoroszlai] and [~hanishakoneru] since you've made changes to the {{@Parameterized.Parameters}} before, and I need your input on whether to just disable the 3 failing tests when {{ozone.om.enable.filesystem.paths}} is enabled (they are failing because the parameterized test is properly initialized with the patch now), or fix these tests in some way.
> A list of failing tests when {{ozone.om.enable.filesystem.paths}} is enabled:
> {code:java|title=TestRootedOzoneFileSystem}
> testDeleteCreatesFakeParentDir
> testMkdirOnNonExistentVolumeBucketDir
> testListStatusRootAndVolumeContinuation
> {code}
> I have fixed {{testListStatusRootAndVolumeNonRecursive}} when it was failing when ACL is enabled (due to volume LIST ACL permission) myself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org