You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "horizonzy (via GitHub)" <gi...@apache.org> on 2023/04/14 03:40:02 UTC
[GitHub] [bookkeeper] horizonzy opened a new pull request, #3918: Fix isWritable incorrect problem.
horizonzy opened a new pull request, #3918:
URL: https://github.com/apache/bookkeeper/pull/3918
### Motivation
The `isWritable` should be false in some places, correct it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a diff in pull request #3918: Fix isWritable incorrect problem.
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #3918:
URL: https://github.com/apache/bookkeeper/pull/3918#discussion_r1168091521
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1097,7 +1097,7 @@ private void closeInternal(boolean permanent, boolean wait) {
}
toClose = channel;
channel = null;
- makeWritable();
+ makeUnWritable();
Review Comment:
The writable should be a reflection value of the Channel's isWritable. So we make it default to true. So it should always be true except when the channel is non-writable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3918: Fix isWritable incorrect problem.
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on PR #3918:
URL: https://github.com/apache/bookkeeper/pull/3918#issuecomment-1507882809
@dlg99 cc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy closed pull request #3918: Fix isWritable incorrect problem.
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy closed pull request #3918: Fix isWritable incorrect problem.
URL: https://github.com/apache/bookkeeper/pull/3918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a diff in pull request #3918: Fix isWritable incorrect problem.
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #3918:
URL: https://github.com/apache/bookkeeper/pull/3918#discussion_r1168091521
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1097,7 +1097,7 @@ private void closeInternal(boolean permanent, boolean wait) {
}
toClose = channel;
channel = null;
- makeWritable();
+ makeUnWritable();
Review Comment:
The writable should be a reflection value in the PerChannelBookieClient of the Channel's isWritable. So we make it default to true. It should always be true except when the channel is non-writable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a diff in pull request #3918: Fix isWritable incorrect problem.
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #3918:
URL: https://github.com/apache/bookkeeper/pull/3918#discussion_r1168091521
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1097,7 +1097,7 @@ private void closeInternal(boolean permanent, boolean wait) {
}
toClose = channel;
channel = null;
- makeWritable();
+ makeUnWritable();
Review Comment:
The writable should be a reflection value in the PerChannelBookieClient of the Channel's isWritable. So we make it default to true. So it should always be true except when the channel is non-writable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org