You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/23 14:34:03 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30470: [SPARK-33495][BUILD] Remove commons-logging.jar's dependency

AngersZhuuuu commented on a change in pull request #30470:
URL: https://github.com/apache/spark/pull/30470#discussion_r528745334



##########
File path: pom.xml
##########
@@ -570,12 +570,6 @@
         <artifactId>commons-beanutils</artifactId>
         <version>1.9.4</version>
       </dependency>
-      <dependency>
-        <groupId>commons-logging</groupId>
-        <artifactId>commons-logging</artifactId>
-        <!-- Hive uses commons-logging 1.1.3 from 0.13 to 1.2 -->
-        <version>1.1.3</version>

Review comment:
       > Could you manual test if we can connect Hive 0.13 - Hive-1.2 after removing commons-logging?
   
   Yea, our env is hive 1.2.1, I will test this later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org