You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/20 11:16:45 UTC

[GitHub] [apisix] spacewander opened a new pull request, #6892: fix: upgrade lua-resty-etcd to 1.6.1

spacewander opened a new pull request, #6892:
URL: https://github.com/apache/apisix/pull/6892

   Signed-off-by: spacewander <sp...@gmail.com>
   
   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes #6887
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #6892: fix: upgrade lua-resty-etcd to 1.6.2

Posted by GitBox <gi...@apache.org>.
spacewander merged PR #6892:
URL: https://github.com/apache/apisix/pull/6892


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-6443 commented on pull request #6892: fix: upgrade lua-resty-etcd to 1.6.1

Posted by GitBox <gi...@apache.org>.
nic-6443 commented on PR #6892:
URL: https://github.com/apache/apisix/pull/6892#issuecomment-1104612223

   > `t/node/route-delete.t` is not passed after upgrading to v1.6.1 (note that it isn't 100% reproducible).
   > 
   > I tried it locally and when I reverted the commit [api7/lua-resty-etcd@5347a42](https://github.com/api7/lua-resty-etcd/commit/5347a428b7d4eab5c064746c92148daf882edac1), the test can be passed again (I tested it 10 times, 10 times passed).
   > 
   > @nic-6443 Could you take a look?
   
   ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-6443 commented on pull request #6892: fix: upgrade lua-resty-etcd to 1.6.1

Posted by GitBox <gi...@apache.org>.
nic-6443 commented on PR #6892:
URL: https://github.com/apache/apisix/pull/6892#issuecomment-1107366051

   @spacewander 
   I got the reason why the `t/node/route-delete.t` test failed. When the last chunk in an event only has a newline, it will cause a delay in event processing. I have submitted a fix PR to lua-resty-etcd: https://github.com/api7/lua-resty-etcd/pull/156
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #6892: fix: upgrade lua-resty-etcd to 1.6.1

Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #6892:
URL: https://github.com/apache/apisix/pull/6892#issuecomment-1103868002

   `t/node/route-delete.t` is not passed after upgrading to v1.6.1 (note that it isn't 100% reproducible).
   
   I tried it locally and when I reverted the commit https://github.com/api7/lua-resty-etcd/commit/5347a428b7d4eab5c064746c92148daf882edac1, the test can be passed again  (I tested it 10 times, 10 times passed).
   
   @nic-6443 Could you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org