You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2021/08/14 19:47:00 UTC

[jira] [Resolved] (CALCITE-4724) ClickHouseSqlDialect `supportsAliasedValues` should return false.

     [ https://issues.apache.org/jira/browse/CALCITE-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-4724.
----------------------------------
    Fix Version/s: 1.28.0
       Resolution: Fixed

Fixed in [d64fd6|https://github.com/apache/calcite/commit/d64fd60477b7c9a15473d89b350fc80c2151ee6e]; thanks for the PR, [~Enze]!

> ClickHouseSqlDialect `supportsAliasedValues` should return false.
> -----------------------------------------------------------------
>
>                 Key: CALCITE-4724
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4724
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.27.0
>            Reporter: Enze Liu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> We use ClickHouseSqlDialect to do some sql optimize. 
> for sql `select 1`, in the process of sqlNode -> relNode -> sqlNode, the sql string will be transformed to 
> {code:java}
> SELECT *
> FROM (VALUES (1)) AS `t` (`EXPR$0`)
> {code}
> Since clickhouse is not support AliasedValues, all we need to do is to extend ClickHouseSqlDialect and make `supportsAliasedValues` return false. 
> Maybe this kind of behavior can integrated into core? 
> If needed, the pull request is ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)