[GitHub] markusthoemmes commented on a change in pull request #3710: Make REST communication with action containers more robust

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3710: Make REST communication with action containers more robust
URL: https://github.com/apache/incubator-openwhisk/pull/3710#discussion_r191331851
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
 ##########
 @@ -141,14 +166,15 @@ protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxRe
 object HttpUtils {
 
   /** A helper method to post one single request to a connection. Used for container tests. */
-  def post(host: String, port: Int, endPoint: String, content: JsValue): (Int, Option[JsObject]) = {
+  def post(host: String, port: Int, endPoint: String, content: JsValue)(implicit logging: Logging,
+                                                                        tid: TransactionId): (Int, Option[JsObject]) = {
     val connection = new HttpUtils(s"$host:$port", 90.seconds, 1.MB)
     val response = connection.post(endPoint, content, retry = true)
     connection.close()
     response match {
       case Right(r)                   => (r.statusCode, Try(r.entity.parseJson.asJsObject).toOption)
       case Left(NoResponseReceived()) => throw new IllegalStateException("no response from container")
-      case Left(Timeout())            => throw new java.util.concurrent.TimeoutException()
+      case Left(Timeout(t))           => throw new java.util.concurrent.TimeoutException()
 
 Review comment:
   Could drop the value (i.e. use `Timeout(_)`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services