You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/03/25 14:35:10 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12331: Fix:
barBorderRadius didn't work
susiwen8 opened a new pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fix barBorderRadius didn't work, not only background but also item
### Fixed issues
Close #12321
## Details
<img width="1097" alt="Screen Shot 2020-03-25 at 22 33 11" src="https://user-images.githubusercontent.com/20318608/77547939-d009e980-6ee8-11ea-84f5-c101d93dd316.png">
### After: How is it fixed in this PR?
<img width="1024" alt="Screen Shot 2020-03-25 at 22 32 32" src="https://user-images.githubusercontent.com/20318608/77547978-dc8e4200-6ee8-11ea-895a-112dc646efa8.png">
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request
#12331: Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#discussion_r398716427
##########
File path: src/layout/barGrid.js
##########
@@ -478,7 +478,8 @@ export function layout(seriesType, ecModel) {
x: x,
y: y,
width: width,
- height: height
+ height: height,
+ rb: seriesModel.get('backgroundStyle.barBorderRadius')
});
Review comment:
`radius` is not a layout related property. So I think it's better to set the property here.
https://github.com/apache/incubator-echarts/blob/b4b979a2fb9ad97493e7efb7c4d64055325ad214/src/chart/bar/BarView.js#L146
```js
bgEl.setShape('r', backgroundModel.get('barBorderRadius'));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12331:
Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#issuecomment-603874420
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request
#12331: Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#discussion_r397934998
##########
File path: src/layout/barGrid.js
##########
@@ -478,7 +478,9 @@ export function layout(seriesType, ecModel) {
x: x,
y: y,
width: width,
- height: height
+ height: height,
+ r: seriesModel.get('barBorderRadius'),
Review comment:
I believe this should be `itemModel.get('barBorderRadius')`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request
#12331: Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#discussion_r398605488
##########
File path: src/layout/barGrid.js
##########
@@ -478,7 +478,9 @@ export function layout(seriesType, ecModel) {
x: x,
y: y,
width: width,
- height: height
+ height: height,
+ r: seriesModel.get('barBorderRadius'),
Review comment:
@pissang item border radius wasn't set from here. so I have it removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request
#12331: Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#discussion_r398713136
##########
File path: src/chart/bar/BarView.js
##########
@@ -673,6 +675,7 @@ function createBackgroundShape(isHorizontalOrRadial, layout, coord) {
return {
x: isHorizontalOrRadial ? layout.x : coordLayout.x,
y: isHorizontalOrRadial ? coordLayout.y : layout.y,
+ r: isHorizontalOrRadial ? layout.r : coordLayout.r,
width: isHorizontalOrRadial ? layout.width : coordLayout.width,
Review comment:
I think it should be `layout.rb` here. Also coordLayout is a rect. It don't have r property.
Also, I prefer not to put `radius` in the layout. See comment below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request
#12331: Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#discussion_r398710842
##########
File path: src/chart/bar/BarView.js
##########
@@ -440,6 +441,7 @@ var getLayout = {
return {
x: layout.x + signX * fixedLineWidth / 2,
y: layout.y + signY * fixedLineWidth / 2,
+ r: layout.rb,
width: layout.width - signX * fixedLineWidth,
Review comment:
This layout is used for bar rect element. `r` property here will not be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12331: Fix:
barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12331:
Fix: barBorderRadius didn't work
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12331: Fix: barBorderRadius didn't work
URL: https://github.com/apache/incubator-echarts/pull/12331#issuecomment-605645808
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org