You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2017/05/04 07:39:25 UTC

[Bug 61067] New: ProxyWebsocketIdleTimeout documentation - wrong time unit

https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

            Bug ID: 61067
           Summary: ProxyWebsocketIdleTimeout documentation - wrong time
                    unit
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_proxy_wstunnel
          Assignee: bugs@httpd.apache.org
          Reporter: a.abfalterer@gmail.com
  Target Milestone: ---

Hi,

ProxyWebsocketIdleTimeout expects its configuration value in time unit
"seconds". The documentation of the directive says milliseconds - which is not
correct.

Cheers, Armin

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

--- Comment #2 from Luca Toscano <to...@gmail.com> ---
Hi Armin,

thanks a lot for the report. I checked and we use ap_timeout_parameter_parse
for the ProxyWebsocketIdleTimeout, and this is its description:

 * Parse a given timeout parameter string into an apr_interval_time_t value.
 * The unit of the time interval is given as postfix string to the numeric
 * string. Currently the following units are understood:
 *
 * ms    : milliseconds
 * s     : seconds
 * mi[n] : minutes
 * h     : hours
 *
 * If no unit is contained in the given timeout parameter the default_time_unit
 * will be used instead.

So in this case the doc is saying that if you append "ms" to the number (eg.
ProxyWebsocketIdleTimeout 100ms) it will be milliseconds, otherwise seconds
(eg. ProxyWebsocketIdleTimeout 100).

Maybe we could add a better explanation, it is not super clear.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

Armin Abfalterer <a....@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Armin Abfalterer <a....@gmail.com> ---
https://httpd.apache.org/docs/trunk/mod/mod_proxy_wstunnel.html#proxywebsocketidletimeout

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

--- Comment #3 from Luca Toscano <to...@gmail.com> ---
Tried to fix with r1794044. What do you think about
https://httpd.apache.org/docs/trunk/mod/mod_proxy_wstunnel.html#proxywebsocketidletimeout
now?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

Luca Toscano <to...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

--- Comment #6 from Armin Abfalterer <a....@gmail.com> ---
sorry, the browser chache fooled me

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

--- Comment #5 from Luca Toscano <to...@gmail.com> ---
https://httpd.apache.org/docs/trunk/mod/mod_proxy_wstunnel.html#proxywebsocketidletimeout
shows updated to me, maybe cached content on the browser? Or maybe I missed
your point about trunk docs not being updated :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 61067] ProxyWebsocketIdleTimeout documentation - wrong time unit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61067

--- Comment #4 from Armin Abfalterer <a....@gmail.com> ---
(In reply to Luca Toscano from comment #3)
> Tried to fix with r1794044. What do you think about

Much better, thanks!

> https://httpd.apache.org/docs/trunk/mod/mod_proxy_wstunnel.
> html#proxywebsocketidletimeout now?

However, the change is not yet shown on httpd.apache.org/docs of trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org