Re: [PR] Implementing masking for task SDK logs [airflow]

["kaxil (via GitHub)" <gi...@apache.org>]

kaxil commented on code in PR #48186:
URL: https://github.com/apache/airflow/pull/48186#discussion_r2009933664


##########
task-sdk/src/airflow/sdk/log.py:
##########
@@ -96,6 +96,13 @@ def redact_jwt(logger: Any, method_name: str, event_dict: EventDict) -> EventDic
     return event_dict
 
 
+def mask_logs(logger: Any, method_name: str, event_dict: EventDict) -> EventDict:
+    from airflow.sdk.execution_time.secrets_masker import redact
+
+    event_dict["event"] = redact(event_dict["event"])
+    return event_dict

Review Comment:
   Could you add a simple test case for it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org