[GitHub] [spark] JoshRosen commented on a diff in pull request #37713: [SPARK-40261][CORE]Exclude TaskResult metadata when calculating result size

[GitBox <gi...@apache.org>]

JoshRosen commented on code in PR #37713:
URL: https://github.com/apache/spark/pull/37713#discussion_r957829146


##########
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala:
##########
@@ -73,7 +73,7 @@ private[spark] class TaskResultGetter(sparkEnv: SparkEnv, scheduler: TaskSchedul
               // We should call it here, so that when it's called again in
               // "TaskSetManager.handleSuccessfulTask", it does not need to deserialize the value.
               directResult.value(taskResultSerializer.get())
-              (directResult, serializedData.limit())
+              (directResult, directResult.valueBytes.limit())

Review Comment:
   We might want to keep this `size` calculation unchanged in order to be consistent with how `IndirectTaskResult.size` is calculated:
   
   https://github.com/apache/spark/blob/c95ed826e23fdec6e1a779cfebde7b3364594fb5/core/src/main/scala/org/apache/spark/executor/Executor.scala#L656-L666
   
   There, it's calculated by first serializing the result into a `DirectTaskResult` and then taking its size.
   
   If we roll back the change to this line then the old definition of `size` will still be used (ensuring that we're consistent w.r.t. the old meaning of the result size internal accumulator that's populated from `size`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org