You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/12/28 02:06:54 UTC

Review Request 64849: Added authentication to some example frameworks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-5362 and MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-5362
    https://issues.apache.org/jira/browse/MESOS-8357


Repository: mesos


Description
-------

All example frameworks now support authenticating when registering
to the master.


Diffs
-----

  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 


Diff: https://reviews.apache.org/r/64849/diff/1/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/#review195141
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On Jan. 9, 2018, 3:19 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64849/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 3:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-5362 and MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-5362
>     https://issues.apache.org/jira/browse/MESOS-8357
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> All example frameworks now support authenticating when registering
> to the master.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64849/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/
-----------------------------------------------------------

(Updated Jan. 30, 2018, 11:59 p.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-5362 and MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-5362
    https://issues.apache.org/jira/browse/MESOS-8357


Repository: mesos


Description
-------

All example frameworks now support authenticating when registering
to the master.


Diffs (updated)
-----

  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
  src/tests/persistent_volume_framework_test.sh 2ab22c03e573d4801c73957f9cad2939b3d3174b 


Diff: https://reviews.apache.org/r/64849/diff/5/

Changes: https://reviews.apache.org/r/64849/diff/4-5/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 7:01 p.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Changes
-------

Rebase on rebase fixup.


Bugs: MESOS-5362 and MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-5362
    https://issues.apache.org/jira/browse/MESOS-8357


Repository: mesos


Description
-------

All example frameworks now support authenticating when registering
to the master.


Diffs (updated)
-----

  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
  src/tests/persistent_volume_framework_test.sh 2ab22c03e573d4801c73957f9cad2939b3d3174b 


Diff: https://reviews.apache.org/r/64849/diff/4/

Changes: https://reviews.apache.org/r/64849/diff/3-4/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Till Toenshoff <to...@me.com>.

> On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote:
> > src/examples/dynamic_reservation_framework.cpp
> > Line 41 (original)
> > <https://reviews.apache.org/r/64849/diff/3/?file=1940016#file1940016line43>
> >
> >     Any particular reason you deleted these?

Improving consistency as that is the greater goal of this chain. Most other examples did not need them - this example also does not benefit. ie. `cerr` is being referenced once, adding a `using` for that seemed to add more boilerplate than needed.


> On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote:
> > src/examples/persistent_volume_framework.cpp
> > Line 501 (original)
> > <https://reviews.apache.org/r/64849/diff/3/?file=1940017#file1940017line503>
> >
> >     Why did you revert this change introduced in the previous review?

Initially, I thought I'ld simply leave it as this todo but then decided to go the extra mile and covering it as well in this chain.


> On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote:
> > src/examples/test_http_framework.cpp
> > Line 401 (original), 390 (patched)
> > <https://reviews.apache.org/r/64849/diff/3/?file=1940018#file1940018line405>
> >
> >     aah you fixed in this review!

Yeah, that was a rebase slipup.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/#review195515
-----------------------------------------------------------


On Jan. 17, 2018, 7:01 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64849/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 7:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-5362 and MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-5362
>     https://issues.apache.org/jira/browse/MESOS-8357
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> All example frameworks now support authenticating when registering
> to the master.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
>   src/tests/persistent_volume_framework_test.sh 2ab22c03e573d4801c73957f9cad2939b3d3174b 
> 
> 
> Diff: https://reviews.apache.org/r/64849/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/#review195515
-----------------------------------------------------------




src/examples/dynamic_reservation_framework.cpp
Line 41 (original)
<https://reviews.apache.org/r/64849/#comment274706>

    Any particular reason you deleted these?



src/examples/persistent_volume_framework.cpp
Line 501 (original)
<https://reviews.apache.org/r/64849/#comment274707>

    Why did you revert this change introduced in the previous review?



src/examples/test_http_framework.cpp
Line 401 (original), 390 (patched)
<https://reviews.apache.org/r/64849/#comment274708>

    aah you fixed in this review!


- Vinod Kone


On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64849/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-5362 and MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-5362
>     https://issues.apache.org/jira/browse/MESOS-8357
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> All example frameworks now support authenticating when registering
> to the master.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
>   src/tests/persistent_volume_framework_test.sh 2ab22c03e573d4801c73957f9cad2939b3d3174b 
> 
> 
> Diff: https://reviews.apache.org/r/64849/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/
-----------------------------------------------------------

(Updated Jan. 15, 2018, 12:29 a.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-5362 and MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-5362
    https://issues.apache.org/jira/browse/MESOS-8357


Repository: mesos


Description
-------

All example frameworks now support authenticating when registering
to the master.


Diffs (updated)
-----

  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
  src/tests/persistent_volume_framework_test.sh 2ab22c03e573d4801c73957f9cad2939b3d3174b 


Diff: https://reviews.apache.org/r/64849/diff/3/

Changes: https://reviews.apache.org/r/64849/diff/2-3/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64849: Added authentication to some example frameworks.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64849/
-----------------------------------------------------------

(Updated Jan. 9, 2018, 3:19 a.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-5362 and MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-5362
    https://issues.apache.org/jira/browse/MESOS-8357


Repository: mesos


Description
-------

All example frameworks now support authenticating when registering
to the master.


Diffs (updated)
-----

  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 


Diff: https://reviews.apache.org/r/64849/diff/2/

Changes: https://reviews.apache.org/r/64849/diff/1-2/


Testing
-------

make check


Thanks,

Till Toenshoff