You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/06/01 19:15:10 UTC
[GitHub] [hive] belugabehr opened a new pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
belugabehr opened a new pull request #2339:
URL: https://github.com/apache/hive/pull/2339
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr merged pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
belugabehr merged pull request #2339:
URL: https://github.com/apache/hive/pull/2339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2339:
URL: https://github.com/apache/hive/pull/2339#issuecomment-854867669
@pgaref @abstractdog Are you able to take a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r647514577
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
poolLock.lock();
try {
while ((result = pool.poll()) == null) {
- notEmpty.await(100, TimeUnit.MILLISECONDS);
+ LOG.info("Awaiting Tez session to become available in session pool");
+ notEmpty.await(10, TimeUnit.SECONDS);
Review comment:
@pgaref This is not just a loop-and-sleep. The `notEmpty` condition will be alerted when a session becomes available and this thread will run again to pickup the session. I don't really understand why there is a timeout currently implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r643513763
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
poolLock.lock();
try {
while ((result = pool.poll()) == null) {
- notEmpty.await(100, TimeUnit.MILLISECONDS);
+ LOG.info("Awaiting Tez session to become available in session pool");
+ notEmpty.await(10, TimeUnit.SECONDS);
Review comment:
You are changing the waiting time to 10s from 100s. If this is intentional, then it shouldn't be put into a commit where the commit message says that it's about improving logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r647504478
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
poolLock.lock();
try {
while ((result = pool.poll()) == null) {
- notEmpty.await(100, TimeUnit.MILLISECONDS);
+ LOG.info("Awaiting Tez session to become available in session pool");
+ notEmpty.await(10, TimeUnit.SECONDS);
Review comment:
Any chance this change can increase the time we actually wait to get a session from the pool assuming there is none currently available?
It looks to me that if the next session becomes available in the next 10ms with the new change we might wait 10s instead -- am I missing something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r643585446
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
poolLock.lock();
try {
while ((result = pool.poll()) == null) {
- notEmpty.await(100, TimeUnit.MILLISECONDS);
+ LOG.info("Awaiting Tez session to become available in session pool");
+ notEmpty.await(10, TimeUnit.SECONDS);
Review comment:
Hello @miklosgergely. The current change wait for 100ms whereas I have changed this to wait until 10s. I'm not sure what the value is of setting a timeout, it will always just loop again. Since I do not see any value here, but I wouldn't want to remove this `wait` altogether as part of this ticket, I simply increased it. Logging once every 100ms would be far too verbose. So you see, this change is logging-related. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r647518347
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
poolLock.lock();
try {
while ((result = pool.poll()) == null) {
- notEmpty.await(100, TimeUnit.MILLISECONDS);
+ LOG.info("Awaiting Tez session to become available in session pool");
+ notEmpty.await(10, TimeUnit.SECONDS);
Review comment:
Right, this is done as part of putSessionBack() method -- so I dont see an issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r643585446
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
poolLock.lock();
try {
while ((result = pool.poll()) == null) {
- notEmpty.await(100, TimeUnit.MILLISECONDS);
+ LOG.info("Awaiting Tez session to become available in session pool");
+ notEmpty.await(10, TimeUnit.SECONDS);
Review comment:
Hello @miklosgergely. The current change wait for 100ms whereas I have changed this to wait until 10s. I'm not sure what the value is of setting a timeout, it will always just loop again. Since I do not see any value here, but I wouldn't want to remove this as part of this ticket, I simply increased it. Logging once every 100ms would be far too verbose. So you see, this change is logging-related. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org