You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/04 08:41:12 UTC

[GitHub] [flink] aljoscha opened a new pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

aljoscha opened a new pull request #12479:
URL: https://github.com/apache/flink/pull/12479


   This fixes two possible sources of instability:
    - not reading all the messages because of timeout
    - clashes in topic names, which lead to double counting


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638721700


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704",
       "triggerID" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c7be46e975aaaef574cc3620169a3b3178b310e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2c7be46e975aaaef574cc3620169a3b3178b310e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1bef9a6921ec7d86739b7d6821b6f23f8602bd1b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704) 
   * 2c7be46e975aaaef574cc3620169a3b3178b310e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638721700


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704",
       "triggerID" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1bef9a6921ec7d86739b7d6821b6f23f8602bd1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638721700


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704",
       "triggerID" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1bef9a6921ec7d86739b7d6821b6f23f8602bd1b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638753608


   We should do the same for the `org.apache.flink.tests.util.kafka.SQLClientKafkaITCase`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638721700


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704",
       "triggerID" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c7be46e975aaaef574cc3620169a3b3178b310e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2739",
       "triggerID" : "2c7be46e975aaaef574cc3620169a3b3178b310e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1bef9a6921ec7d86739b7d6821b6f23f8602bd1b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704) 
   * 2c7be46e975aaaef574cc3620169a3b3178b310e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2739) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-639482743


   Thanks again for the thorough reviews, @zentol! 🍵


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638721700


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1bef9a6921ec7d86739b7d6821b6f23f8602bd1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638721700


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2704",
       "triggerID" : "1bef9a6921ec7d86739b7d6821b6f23f8602bd1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c7be46e975aaaef574cc3620169a3b3178b310e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2739",
       "triggerID" : "2c7be46e975aaaef574cc3620169a3b3178b310e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c7be46e975aaaef574cc3620169a3b3178b310e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2739) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha closed pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12479:
URL: https://github.com/apache/flink/pull/12479


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638708092


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 1bef9a6921ec7d86739b7d6821b6f23f8602bd1b (Thu Jun 04 08:45:36 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638807023


   Good catch! I'll do that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638844041


   I pushed the same changes also for `SQLClientKafkaITCase`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on pull request #12479: [FLINK-17260] Fix StreamingKafkaITCase instabilities

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12479:
URL: https://github.com/apache/flink/pull/12479#issuecomment-638806543


   The overall changes are fine though; so +1 once the SQLClientKafkaITCase was adjusted in a similar fashion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org