You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2007/01/31 19:16:05 UTC
[jira] Created: (WSCOMMONS-159) OMSourcedElementImpl serialize()
violates OMNode.serialize()
OMSourcedElementImpl serialize() violates OMNode.serialize()
-------------------------------------------------------------
Key: WSCOMMONS-159
URL: https://issues.apache.org/jira/browse/WSCOMMONS-159
Project: WS-Commons
Issue Type: Bug
Components: AXIOM
Reporter: Rich Scheuerle
The OMNode serialize method indicates that the OM is cached.
/**
* Serializes the node with caching.
*
* @param xmlWriter
* @throws XMLStreamException
*/
public void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
But OMSourcedElementImpl consumes the message. This results in errors when an OM tree contains a mixture of normal nodes and OMSourcedElements.
The solution is to change OMSourcedElement to respect the OMNode "serialize" contracts.
I am working on a patch containing the corrected code and validation tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Resolved: (WSCOMMONS-159) OMSourcedElementImpl serialize()
violates OMNode.serialize()
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rich Scheuerle resolved WSCOMMONS-159.
--------------------------------------
Resolution: Fixed
Committed revision 502068.
> OMSourcedElementImpl serialize() violates OMNode.serialize()
> -------------------------------------------------------------
>
> Key: WSCOMMONS-159
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-159
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Rich Scheuerle
> Assigned To: Rich Scheuerle
> Attachments: patch.txt
>
>
> The OMNode serialize method indicates that the OM is cached.
> /**
> * Serializes the node with caching.
> *
> * @param xmlWriter
> * @throws XMLStreamException
> */
> public void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
> But OMSourcedElementImpl consumes the message. This results in errors when an OM tree contains a mixture of normal nodes and OMSourcedElements.
> The solution is to change OMSourcedElement to respect the OMNode "serialize" contracts.
> I am working on a patch containing the corrected code and validation tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Updated: (WSCOMMONS-159) OMSourcedElementImpl serialize()
violates OMNode.serialize()
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rich Scheuerle updated WSCOMMONS-159:
-------------------------------------
Attachment: patch.txt
Here is the patch containing the change to OMSourcedElementImpl and some new validating tests.
I will commit this change after I run the axis2 tests
> OMSourcedElementImpl serialize() violates OMNode.serialize()
> -------------------------------------------------------------
>
> Key: WSCOMMONS-159
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-159
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Rich Scheuerle
> Assigned To: Rich Scheuerle
> Attachments: patch.txt
>
>
> The OMNode serialize method indicates that the OM is cached.
> /**
> * Serializes the node with caching.
> *
> * @param xmlWriter
> * @throws XMLStreamException
> */
> public void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
> But OMSourcedElementImpl consumes the message. This results in errors when an OM tree contains a mixture of normal nodes and OMSourcedElements.
> The solution is to change OMSourcedElement to respect the OMNode "serialize" contracts.
> I am working on a patch containing the corrected code and validation tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Commented: (WSCOMMONS-159) OMSourcedElementImpl serialize()
violates OMNode.serialize()
Posted by "Nick Gallardo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469147 ]
Nick Gallardo commented on WSCOMMONS-159:
-----------------------------------------
This would be a very helpful fix. I agree with Rich that even though it's an OMSourcedElement, it should still respect the OMNode interface and cache the contents rather than consuming.
> OMSourcedElementImpl serialize() violates OMNode.serialize()
> -------------------------------------------------------------
>
> Key: WSCOMMONS-159
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-159
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Rich Scheuerle
> Assigned To: Rich Scheuerle
> Attachments: patch.txt
>
>
> The OMNode serialize method indicates that the OM is cached.
> /**
> * Serializes the node with caching.
> *
> * @param xmlWriter
> * @throws XMLStreamException
> */
> public void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
> But OMSourcedElementImpl consumes the message. This results in errors when an OM tree contains a mixture of normal nodes and OMSourcedElements.
> The solution is to change OMSourcedElement to respect the OMNode "serialize" contracts.
> I am working on a patch containing the corrected code and validation tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Assigned: (WSCOMMONS-159) OMSourcedElementImpl serialize()
violates OMNode.serialize()
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rich Scheuerle reassigned WSCOMMONS-159:
----------------------------------------
Assignee: Rich Scheuerle
> OMSourcedElementImpl serialize() violates OMNode.serialize()
> -------------------------------------------------------------
>
> Key: WSCOMMONS-159
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-159
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Rich Scheuerle
> Assigned To: Rich Scheuerle
>
> The OMNode serialize method indicates that the OM is cached.
> /**
> * Serializes the node with caching.
> *
> * @param xmlWriter
> * @throws XMLStreamException
> */
> public void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
> But OMSourcedElementImpl consumes the message. This results in errors when an OM tree contains a mixture of normal nodes and OMSourcedElements.
> The solution is to change OMSourcedElement to respect the OMNode "serialize" contracts.
> I am working on a patch containing the corrected code and validation tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org