You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by ThisuraThejith <gi...@git.apache.org> on 2017/08/01 23:48:32 UTC
[GitHub] fineract pull request #397: Integrated TOIF into apache-fineract
GitHub user ThisuraThejith opened a pull request:
https://github.com/apache/fineract/pull/397
Integrated TOIF into apache-fineract
* Reports are generated in appache-fineract/reports/toif
* Task is not executed upon build, due to time restriction
* ./gradlew toif will run the scanning task
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThisuraThejith/incubator-fineract TOIF_Integration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/fineract/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
commit e0c3d788f297fc7a410330aa6afc7923473cf78b
Author: ThisuraThejith <tt...@gmail.com>
Date: 2017-08-01T01:44:12Z
integrated TOIF into apache-fineract
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #397: Integrated TOIF into apache-fineract
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/397#discussion_r132120780
--- Diff: fineract-provider/toif/housekeeping/housekeeping.txt ---
@@ -0,0 +1,36 @@
+###########################
+# Facts
+###########################
+
+TOIFSegmentIsRelatedToProject=project1
+TOIFSegmentIsProducedByOrganization=org1
+TOIFSegmentIsOwnedByOrganization=org1
+TOIFSegmentIsGeneratedByPerson=person1
+TOIFSegmentIsSupervisedByPerson=person1
+
+PersonIsInvolvedInProjectAsRole=person1;project1;role1
+OrganizationIsInvolvedInProjectAsRole=org1;project1;role2
+OrganizationIsPartOfOrganizationAsRole=org1;org2;role2
+PersonIsEmployedByOrganizationAsRole=person1;org1;role1
+
+###########################
+# Entities
+###########################
+
+SegmentDescription=Segment.
+
+#projectId=name;description
+project1=apache-fineract;Apache Fineract:A Platform for Microfinance.
+
+#personId=name;email;phone
+person1=mifos-developer;dev@fineract.apache.org;555-1234
--- End diff --
Suggest not to have mifos names as this is Apache product now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #397: Integrated TOIF into apache-fineract
Posted by avikganguly01 <gi...@git.apache.org>.
Github user avikganguly01 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/397#discussion_r143773876
--- Diff: fineract-provider/toif/housekeeping/housekeeping.txt ---
@@ -0,0 +1,36 @@
+###########################
+# Facts
+###########################
+
+TOIFSegmentIsRelatedToProject=project1
+TOIFSegmentIsProducedByOrganization=org1
+TOIFSegmentIsOwnedByOrganization=org1
+TOIFSegmentIsGeneratedByPerson=person1
+TOIFSegmentIsSupervisedByPerson=person1
+
+PersonIsInvolvedInProjectAsRole=person1;project1;role1
+OrganizationIsInvolvedInProjectAsRole=org1;project1;role2
+OrganizationIsPartOfOrganizationAsRole=org1;org2;role2
+PersonIsEmployedByOrganizationAsRole=person1;org1;role1
+
+###########################
+# Entities
+###########################
+
+SegmentDescription=Segment.
+
+#projectId=name;description
+project1=apache-fineract;Apache Fineract:A Platform for Microfinance.
+
+#personId=name;email;phone
+person1=mifos-developer;dev@fineract.apache.org;555-1234
--- End diff --
@ThisuraThejith Can you update your PR with the suggested change so it can be merged?
---
[GitHub] fineract pull request #397: Integrated TOIF into apache-fineract
Posted by ThisuraThejith <gi...@git.apache.org>.
Github user ThisuraThejith commented on a diff in the pull request:
https://github.com/apache/fineract/pull/397#discussion_r138241483
--- Diff: fineract-provider/toif/housekeeping/housekeeping.txt ---
@@ -0,0 +1,36 @@
+###########################
+# Facts
+###########################
+
+TOIFSegmentIsRelatedToProject=project1
+TOIFSegmentIsProducedByOrganization=org1
+TOIFSegmentIsOwnedByOrganization=org1
+TOIFSegmentIsGeneratedByPerson=person1
+TOIFSegmentIsSupervisedByPerson=person1
+
+PersonIsInvolvedInProjectAsRole=person1;project1;role1
+OrganizationIsInvolvedInProjectAsRole=org1;project1;role2
+OrganizationIsPartOfOrganizationAsRole=org1;org2;role2
+PersonIsEmployedByOrganizationAsRole=person1;org1;role1
+
+###########################
+# Entities
+###########################
+
+SegmentDescription=Segment.
+
+#projectId=name;description
+project1=apache-fineract;Apache Fineract:A Platform for Microfinance.
+
+#personId=name;email;phone
+person1=mifos-developer;dev@fineract.apache.org;555-1234
--- End diff --
@nazeer1100126 will do it.
---