You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/24 06:37:45 UTC

[GitHub] [doris] eldenmoon opened a new pull request, #14544: [Fix](array-function) fix `array_distinct` null values

eldenmoon opened a new pull request, #14544:
URL: https://github.com/apache/doris/pull/14544

   in the previous the result is:
   ```
   mysql> select array_distinct([1,1,3,3,null, null, null]);
   +-----------------------------------------------------+
   | array_distinct(ARRAY(1, 1, 3, 3, NULL, NULL, NULL)) |
   +-----------------------------------------------------+
   | [1, 3, NULL, NULL, NULL]                            |
   +-----------------------------------------------------+
   1 row in set (0.00 sec)
   ```
   
   after this fix, the result becomes:
   ```
   mysql> select array_distinct([1,1,3,3,null, null, null]);
   +-----------------------------------------------------+
   | array_distinct(ARRAY(1, 1, 3, 3, NULL, NULL, NULL)) |
   +-----------------------------------------------------+
   | [1, 3, NULL]                                        |
   +-----------------------------------------------------+
   1 row in set (0.00 sec)
   ```
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14544:
URL: https://github.com/apache/doris/pull/14544#issuecomment-1326027326

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14544:
URL: https://github.com/apache/doris/pull/14544#issuecomment-1326092832

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 34.94 seconds
    load time: 443 seconds
    storage size: 17171844166 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221124081216_clickbench_pr_52036.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] cambyzju commented on pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #14544:
URL: https://github.com/apache/doris/pull/14544#issuecomment-1326169942

   > @carlvinhust2012 I don't know spark, but starocks behavior mathes the fixed one, I tested on ClickHouse, the duplicated nulls is also removed from results, this is more matched with user's intuition
   > 
   > https://docs.starrocks.io/en-us/2.4/sql-reference/sql-functions/array-functions/array_distinct
   
   I tested this case on spark, it will remove duplicate nulls.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] dataroaring merged pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #14544:
URL: https://github.com/apache/doris/pull/14544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] carlvinhust2012 commented on pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #14544:
URL: https://github.com/apache/doris/pull/14544#issuecomment-1326056218

   Does this changed behavior follow the spark or starrocks?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14544:
URL: https://github.com/apache/doris/pull/14544#issuecomment-1326027344

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] eldenmoon commented on pull request #14544: [Fix](array-function) fix `array_distinct` null values

Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #14544:
URL: https://github.com/apache/doris/pull/14544#issuecomment-1326077186

   @carlvinhust2012 I don't know spark, but starocks behavior mathes the fixed one, I tested on ClickHouse, the duplicated nulls is also removed from results, this is more matched with user's intuition


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org