[GitHub] zhaijack commented on a change in pull request #368: Issue 360: [documentation] configuration settings

[gi...@git.apache.org]

zhaijack commented on a change in pull request #368: Issue 360: [documentation] configuration settings
URL: https://github.com/apache/bookkeeper/pull/368#discussion_r131053426
 
 

 ##########
 File path: bookkeeper-server/conf/bk_server.conf
 ##########
 @@ -157,22 +176,29 @@ explicitLacInterval = 1
 # Maximum writes to buffer to achieve grouping
 # journalBufferedWritesThreshold=524288
 
+# Maximum entries to buffer to impose on a journal write to achieve grouping.
+# journalBufferedEntriesThreshold=0
+
 # If we should flush the journal when journal queue is empty
 # journalFlushWhenQueueEmpty=false
 
 # The number of threads that should handle journal callbacks
 # numJournalCallbackThreads=1
 
+# The journal format version to write.
+# journalFormatVersionToWrite=4
+
 # How long the interval to trigger next garbage collection, in milliseconds
 # Since garbage collection is running in background, too frequent gc
 # will heart performance. It is better to give a higher number of gc
 # interval if there is enough disk capacity.
 # gcWaitTime=1000
 
-# How long the interval to trigger next garbage collection of overreplicated
-# ledgers, in milliseconds [Default: 1 day]. This should not be run very frequently since we read
-# the metadata for all the ledgers on the bookie from zk
-# gcOverreplicatedLedgerWaitTime=86400000
 
 Review comment:
   thanks. added back.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services