You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/18 19:56:30 UTC

[GitHub] [superset] AAfghahi opened a new pull request #13694: fix: select table overlay

AAfghahi opened a new pull request #13694:
URL: https://github.com/apache/superset/pull/13694


   ### SUMMARY
   The table selector was being renderended underneath the footer and the  modal background. This fixes that by giving the menu a fixed position. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   before:
   ![image](https://user-images.githubusercontent.com/48933336/111689444-6920c700-8802-11eb-90cd-88155651c374.png)
   
   
   after:
   ![Screen Shot 2021-03-18 at 3 53 26 PM](https://user-images.githubusercontent.com/48933336/111689385-573f2400-8802-11eb-9f97-eacfe5074b8d.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: https://github.com/apache/superset/issues/13192
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (df53e0d) into [master](https://codecov.io/gh/apache/superset/commit/be8f8d9c1fc946b0d69871907cc78d9e4e942e42?el=desc) (be8f8d9) will **decrease** coverage by `0.27%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head df53e0d differs from pull request most recent head 27d6b13. Consider uploading reports for the commit 27d6b13 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.50%   77.22%   -0.28%     
   ==========================================
     Files         935      933       -2     
     Lines       47293    47144     -149     
     Branches     5894     5848      -46     
   ==========================================
   - Hits        36654    36407     -247     
   - Misses      10495    10594      +99     
   + Partials      144      143       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.34% <ø> (+0.29%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `63.47% <ø> (-0.23%)` | :arrow_down: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `90.62% <ø> (ø)` | |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
   | [...dashboard/components/menu/MarkdownModeDropdown.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24udHN4) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `85.26% <0.00%> (-4.22%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `80.82% <0.00%> (-3.80%)` | :arrow_down: |
   | ... and [30 more](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [64f967c...27d6b13](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-802401967


   @junlincc Ephemeral environment spinning up at http://34.221.153.20:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (df53e0d) into [master](https://codecov.io/gh/apache/superset/commit/adc247b7e4fade7ef0d68cb07df5e3aa6bf9a677?el=desc) (adc247b) will **decrease** coverage by `0.17%`.
   > The diff coverage is `84.37%`.
   
   > :exclamation: Current head df53e0d differs from pull request most recent head 3094398. Consider uploading reports for the commit 3094398 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.40%   77.22%   -0.18%     
   ==========================================
     Files         924      933       +9     
     Lines       46863    47144     +281     
     Branches     5657     5848     +191     
   ==========================================
   + Hits        36272    36407     +135     
   - Misses      10455    10594     +139     
   - Partials      136      143       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.34% <58.21%> (-0.25%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.47% <76.00%> (+0.32%)` | :arrow_up: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `90.62% <ø> (ø)` | |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (-4.11%)` | :arrow_down: |
   | [...CrossFilterScopingModal/CrossFilterScopingForm.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0udHN4) | `46.15% <ø> (ø)` | |
   | [...rossFilterScopingModal/CrossFilterScopingModal.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsLnRzeA==) | `90.47% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `85.26% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | `97.29% <ø> (ø)` | |
   | ... and [96 more](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [ecfcaea...3094398](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] hughhhh merged pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #13694:
URL: https://github.com/apache/superset/pull/13694


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-805129630


   @junlincc added a couple of datasets, and this current iteration is working the way you want it. 
   
   ![Screen Shot 2021-03-23 at 2 24 31 PM](https://user-images.githubusercontent.com/48933336/112198483-862f0e80-8be3-11eb-8f05-5fa180abe812.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (f60096f) into [master](https://codecov.io/gh/apache/superset/commit/adc247b7e4fade7ef0d68cb07df5e3aa6bf9a677?el=desc) (adc247b) will **decrease** coverage by `4.17%`.
   > The diff coverage is `84.78%`.
   
   > :exclamation: Current head f60096f differs from pull request most recent head 1b0d005. Consider uploading reports for the commit 1b0d005 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.40%   73.22%   -4.18%     
   ==========================================
     Files         924      620     -304     
     Lines       46863    21943   -24920     
     Branches     5657     5818     +161     
   ==========================================
   - Hits        36272    16067   -20205     
   + Misses      10455     5733    -4722     
   - Partials      136      143       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.50% <69.79%> (-0.09%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.39% <75.29%> (+0.24%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `90.62% <ø> (ø)` | |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (-4.11%)` | :arrow_down: |
   | [...CrossFilterScopingModal/CrossFilterScopingForm.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0udHN4) | `46.15% <ø> (ø)` | |
   | [...rossFilterScopingModal/CrossFilterScopingModal.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsLnRzeA==) | `90.47% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `85.26% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | `97.29% <ø> (ø)` | |
   | ... and [371 more](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [ecfcaea...1b0d005](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804393991


   > Thank you for the fix, looks like the first dropdown border is still overlaid.
   
   @junlincc so only the first dropdown isn't working? Does the second one? Sorry for not checking this, the original ticket was only for the last dropdown. My fault, thank you for finding it!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-808277172


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (f60096f) into [master](https://codecov.io/gh/apache/superset/commit/adc247b7e4fade7ef0d68cb07df5e3aa6bf9a677?el=desc) (adc247b) will **decrease** coverage by `4.17%`.
   > The diff coverage is `84.78%`.
   
   > :exclamation: Current head f60096f differs from pull request most recent head 3094398. Consider uploading reports for the commit 3094398 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.40%   73.22%   -4.18%     
   ==========================================
     Files         924      620     -304     
     Lines       46863    21943   -24920     
     Branches     5657     5818     +161     
   ==========================================
   - Hits        36272    16067   -20205     
   + Misses      10455     5733    -4722     
   - Partials      136      143       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.50% <69.79%> (-0.09%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.39% <75.29%> (+0.24%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `90.62% <ø> (ø)` | |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (-4.11%)` | :arrow_down: |
   | [...CrossFilterScopingModal/CrossFilterScopingForm.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0udHN4) | `46.15% <ø> (ø)` | |
   | [...rossFilterScopingModal/CrossFilterScopingModal.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsLnRzeA==) | `90.47% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `85.26% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | `97.29% <ø> (ø)` | |
   | ... and [371 more](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [ecfcaea...3094398](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-802301572


   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (df53e0d) into [master](https://codecov.io/gh/apache/superset/commit/adc247b7e4fade7ef0d68cb07df5e3aa6bf9a677?el=desc) (adc247b) will **decrease** coverage by `0.53%`.
   > The diff coverage is `84.37%`.
   
   > :exclamation: Current head df53e0d differs from pull request most recent head 3094398. Consider uploading reports for the commit 3094398 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.40%   76.86%   -0.54%     
   ==========================================
     Files         924      933       +9     
     Lines       46863    47161     +298     
     Branches     5657     5854     +197     
   ==========================================
   - Hits        36272    36250      -22     
   - Misses      10455    10765     +310     
   - Partials      136      146      +10     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.47% <76.00%> (+0.32%)` | :arrow_up: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `89.32% <ø> (-1.31%)` | :arrow_down: |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `86.02% <ø> (+1.10%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (-4.11%)` | :arrow_down: |
   | [...CrossFilterScopingModal/CrossFilterScopingForm.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0udHN4) | `46.15% <ø> (ø)` | |
   | [...rossFilterScopingModal/CrossFilterScopingModal.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsLnRzeA==) | `90.47% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `85.26% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | `97.29% <ø> (ø)` | |
   | ... and [124 more](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [ecfcaea...3094398](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (df53e0d) into [master](https://codecov.io/gh/apache/superset/commit/adc247b7e4fade7ef0d68cb07df5e3aa6bf9a677?el=desc) (adc247b) will **decrease** coverage by `1.20%`.
   > The diff coverage is `84.21%`.
   
   > :exclamation: Current head df53e0d differs from pull request most recent head 3094398. Consider uploading reports for the commit 3094398 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.40%   76.19%   -1.21%     
   ==========================================
     Files         924      933       +9     
     Lines       46863    47143     +280     
     Branches     5657     5848     +191     
   ==========================================
   - Hits        36272    35920     -352     
   - Misses      10455    11061     +606     
   - Partials      136      162      +26     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.85% <58.77%> (+0.27%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `63.47% <76.00%> (+0.32%)` | :arrow_up: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `88.54% <ø> (-2.09%)` | :arrow_down: |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
   | [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `52.31% <0.00%> (-16.56%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (-4.11%)` | :arrow_down: |
   | [...CrossFilterScopingModal/CrossFilterScopingForm.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0udHN4) | `46.15% <ø> (ø)` | |
   | [...rossFilterScopingModal/CrossFilterScopingModal.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsLnRzeA==) | `90.47% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `85.26% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [143 more](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [ecfcaea...3094398](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13694: fix: select table overlay

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13694:
URL: https://github.com/apache/superset/pull/13694#issuecomment-804415188


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=h1) Report
   > Merging [#13694](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=desc) (927e16d) into [master](https://codecov.io/gh/apache/superset/commit/64f967cb2d65d1cefc2f7a8736a2a6705a709a46?el=desc) (64f967c) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 927e16d differs from pull request most recent head 27d6b13. Consider uploading reports for the commit 27d6b13 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13694      +/-   ##
   ==========================================
   - Coverage   77.45%   77.32%   -0.13%     
   ==========================================
     Files         934      934              
     Lines       47249    47249              
     Branches     5892     5892              
   ==========================================
   - Hits        36595    36534      -61     
   - Misses      10508    10571      +63     
   + Partials      146      144       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <ø> (+0.13%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `63.73% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.65% <0.00%> (-0.46%)` | :arrow_down: |
   | [...e/components/controls/FilterControl/AdhocFilter.js](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyLmpz) | `96.92% <0.00%> (+3.07%)` | :arrow_up: |
   | [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `68.87% <0.00%> (+5.29%)` | :arrow_up: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13694/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=footer). Last update [64f967c...27d6b13](https://codecov.io/gh/apache/superset/pull/13694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org