You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/04/22 02:10:11 UTC

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

zjffdu commented on code in PR #4355:
URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855713929


##########
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java:
##########
@@ -54,11 +57,11 @@ public InterpreterClient launchDirectly(InterpreterLaunchContext context) throws
 
     StandardInterpreterLauncher interpreterLauncher = null;
     if (isSpark()) {
-      interpreterLauncher = new SparkInterpreterLauncher(zConf, recoveryStorage);
+      interpreterLauncher = (StandardInterpreterLauncher) pluginManager.createInterpreterLauncher("SparkInterpreterLauncher", recoveryStorage);

Review Comment:
   SparkInterpreterLauncher ？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org