You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/19 13:55:48 UTC

[GitHub] [incubator-inlong] vernedeng opened a new pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

vernedeng opened a new pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244


   ### Title Name: [INLONG-XYZ][component] Title of the pull request
   
   Fixes #3243 
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830509403



##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/SortSdkSource.java
##########
@@ -207,7 +220,7 @@ private void updateAllClientConfig() {
      * @param config The config to be updated.
      */
     private void updateClientConfig(SortClientConfig config) {
-        config.setManagerApiUrl(CommonPropertiesHolder.getSourceConfigManagerUrl());
+        config.setManagerApiUrl(ManagerAddrGetHandler.getSortSourceConfigUrl());

Review comment:
       in line 243, updateClientConfig is used before init sort client




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830550069



##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/ManagerAddrGetHandler.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.config.holder;
+
+import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.flume.Context;
+import org.apache.flume.conf.Configurable;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.slf4j.Logger;
+
+import java.util.Optional;
+
+/**
+ * Manager address get handler.
+ *
+ * <p> Used to acquire the ip and port of manager, which sort sdk and sort-standalone request config from. </p>
+ * <p> The default implementation is base on {@link CommonPropertiesHolder} to acquire properties. </p>
+ */
+public class ManagerAddrGetHandler implements Configurable {

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830550116



##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/ManagerAddrGetHandler.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.config.holder;
+
+import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.flume.Context;
+import org.apache.flume.conf.Configurable;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.slf4j.Logger;
+
+import java.util.Optional;
+
+/**
+ * Manager address get handler.
+ *
+ * <p> Used to acquire the ip and port of manager, which sort sdk and sort-standalone request config from. </p>
+ * <p> The default implementation is base on {@link CommonPropertiesHolder} to acquire properties. </p>
+ */
+public class ManagerAddrGetHandler implements Configurable {
+
+    private static final Logger LOG = InlongLoggerFactory.getLogger(ManagerAddrGetHandler.class);
+    private static final String KEY_MANAGER_ADDR_GET_HANDLER_TYPE = "ManagerAddrGetHandler";
+    private static final String KEY_SORT_CLUSTER_CONFIG_MANAGER_URL = "sortClusterConfig.managerUrl";
+    private static final String KEY_SORT_SOURCE_CONFIG_MANAGER_URL = "sortSourceConfig.managerUrl";
+
+    private static ManagerAddrGetHandler instance;
+
+    public Context context;
+
+    /**
+     * Delete no argument constructor.
+     */
+    private ManagerAddrGetHandler() {
+
+    }
+
+    /**
+     * Get URL where SortSdk request SortSourceConfig.
+     *
+     * @return URL to get SortSourceConfig.
+     */
+    public static String getSortSourceConfigUrl() {
+        String url = get().context.getString(KEY_SORT_SOURCE_CONFIG_MANAGER_URL);

Review comment:
       fix, use local cache, only get it in the first time




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830500966



##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/SortSdkSource.java
##########
@@ -207,7 +220,7 @@ private void updateAllClientConfig() {
      * @param config The config to be updated.
      */
     private void updateClientConfig(SortClientConfig config) {
-        config.setManagerApiUrl(CommonPropertiesHolder.getSourceConfigManagerUrl());
+        config.setManagerApiUrl(ManagerAddrGetHandler.getSortSourceConfigUrl());

Review comment:
       When common.properties have the key "sortSourceConfig.QueryConsumeConfigType", the method "updateClientConfig" is unusable.

##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/CommonPropertiesHolder.java
##########
@@ -196,22 +200,22 @@ public static Integer getInteger(String key) {
     public static String getClusterId() {
         return getString(KEY_CLUSTER_ID);
     }
-
+    
     /**
-     * Get manager URL
+     * getAuditFormatInterval
      *
-     * @return Manager URL
+     * @return
      */
-    public static String getSourceConfigManagerUrl() {
-        return getString(KEY_SOURCE_CONFIG_MANAGER_URL);
+    public static long getAuditFormatInterval() {
+        return auditFormatInterval;
     }
 
     /**
-     * getAuditFormatInterval
-     * 
+     * get if managerAddrNeedUpdate
+     *
      * @return
      */
-    public static long getAuditFormatInterval() {
-        return auditFormatInterval;
+    public static boolean isManagerAddrNeedUpdate() {

Review comment:
       The method "isManagerAddrNeedUpdate" is unusable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830504928



##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/ManagerAddrGetHandler.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.config.holder;
+
+import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.flume.Context;
+import org.apache.flume.conf.Configurable;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.slf4j.Logger;
+
+import java.util.Optional;
+
+/**
+ * Manager address get handler.
+ *
+ * <p> Used to acquire the ip and port of manager, which sort sdk and sort-standalone request config from. </p>
+ * <p> The default implementation is base on {@link CommonPropertiesHolder} to acquire properties. </p>
+ */
+public class ManagerAddrGetHandler implements Configurable {
+
+    private static final Logger LOG = InlongLoggerFactory.getLogger(ManagerAddrGetHandler.class);
+    private static final String KEY_MANAGER_ADDR_GET_HANDLER_TYPE = "ManagerAddrGetHandler";
+    private static final String KEY_SORT_CLUSTER_CONFIG_MANAGER_URL = "sortClusterConfig.managerUrl";
+    private static final String KEY_SORT_SOURCE_CONFIG_MANAGER_URL = "sortSourceConfig.managerUrl";
+
+    private static ManagerAddrGetHandler instance;
+
+    public Context context;
+
+    /**
+     * Delete no argument constructor.
+     */
+    private ManagerAddrGetHandler() {
+
+    }
+
+    /**
+     * Get URL where SortSdk request SortSourceConfig.
+     *
+     * @return URL to get SortSourceConfig.
+     */
+    public static String getSortSourceConfigUrl() {
+        String url = get().context.getString(KEY_SORT_SOURCE_CONFIG_MANAGER_URL);
+        if (StringUtils.isBlank(url)) {
+            LOG.error("Get SortSourceConfigUrl from CommonPropertiesHolder failed, "
+                    + "please check if there is any property of key {}.", KEY_SORT_SOURCE_CONFIG_MANAGER_URL);
+        }
+        return url;
+    }
+
+    /**
+     * Get URL where Sort-Standalone request SortClusterConfig.
+     *
+     * @return URL to get SortClusterConfig.
+     */
+    public static String getSortClusterConfigUrl() {
+        String url = get().context.getString(KEY_SORT_CLUSTER_CONFIG_MANAGER_URL);

Review comment:
       ditto

##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/ManagerAddrGetHandler.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.config.holder;
+
+import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.flume.Context;
+import org.apache.flume.conf.Configurable;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.slf4j.Logger;
+
+import java.util.Optional;
+
+/**
+ * Manager address get handler.
+ *
+ * <p> Used to acquire the ip and port of manager, which sort sdk and sort-standalone request config from. </p>
+ * <p> The default implementation is base on {@link CommonPropertiesHolder} to acquire properties. </p>
+ */
+public class ManagerAddrGetHandler implements Configurable {
+
+    private static final Logger LOG = InlongLoggerFactory.getLogger(ManagerAddrGetHandler.class);
+    private static final String KEY_MANAGER_ADDR_GET_HANDLER_TYPE = "ManagerAddrGetHandler";
+    private static final String KEY_SORT_CLUSTER_CONFIG_MANAGER_URL = "sortClusterConfig.managerUrl";
+    private static final String KEY_SORT_SOURCE_CONFIG_MANAGER_URL = "sortSourceConfig.managerUrl";
+
+    private static ManagerAddrGetHandler instance;
+
+    public Context context;
+
+    /**
+     * Delete no argument constructor.
+     */
+    private ManagerAddrGetHandler() {
+
+    }
+
+    /**
+     * Get URL where SortSdk request SortSourceConfig.
+     *
+     * @return URL to get SortSourceConfig.
+     */
+    public static String getSortSourceConfigUrl() {
+        String url = get().context.getString(KEY_SORT_SOURCE_CONFIG_MANAGER_URL);

Review comment:
       It is not good to get url from context every time.

##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/ManagerAddrGetHandler.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.config.holder;
+
+import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.flume.Context;
+import org.apache.flume.conf.Configurable;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.slf4j.Logger;
+
+import java.util.Optional;
+
+/**
+ * Manager address get handler.
+ *
+ * <p> Used to acquire the ip and port of manager, which sort sdk and sort-standalone request config from. </p>
+ * <p> The default implementation is base on {@link CommonPropertiesHolder} to acquire properties. </p>
+ */
+public class ManagerAddrGetHandler implements Configurable {

Review comment:
       "Addr" is not good concept.
   ManagerUrlHandler is better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830507054



##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/CommonPropertiesHolder.java
##########
@@ -196,22 +200,22 @@ public static Integer getInteger(String key) {
     public static String getClusterId() {
         return getString(KEY_CLUSTER_ID);
     }
-
+    
     /**
-     * Get manager URL
+     * getAuditFormatInterval
      *
-     * @return Manager URL
+     * @return
      */
-    public static String getSourceConfigManagerUrl() {
-        return getString(KEY_SOURCE_CONFIG_MANAGER_URL);
+    public static long getAuditFormatInterval() {
+        return auditFormatInterval;
     }
 
     /**
-     * getAuditFormatInterval
-     * 
+     * get if managerAddrNeedUpdate
+     *
      * @return
      */
-    public static long getAuditFormatInterval() {
-        return auditFormatInterval;
+    public static boolean isManagerAddrNeedUpdate() {

Review comment:
       maybe this managerAddrNeedUpdate is useless, need further disscuss




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830550118



##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/ManagerAddrGetHandler.java
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.config.holder;
+
+import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.flume.Context;
+import org.apache.flume.conf.Configurable;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.slf4j.Logger;
+
+import java.util.Optional;
+
+/**
+ * Manager address get handler.
+ *
+ * <p> Used to acquire the ip and port of manager, which sort sdk and sort-standalone request config from. </p>
+ * <p> The default implementation is base on {@link CommonPropertiesHolder} to acquire properties. </p>
+ */
+public class ManagerAddrGetHandler implements Configurable {
+
+    private static final Logger LOG = InlongLoggerFactory.getLogger(ManagerAddrGetHandler.class);
+    private static final String KEY_MANAGER_ADDR_GET_HANDLER_TYPE = "ManagerAddrGetHandler";
+    private static final String KEY_SORT_CLUSTER_CONFIG_MANAGER_URL = "sortClusterConfig.managerUrl";
+    private static final String KEY_SORT_SOURCE_CONFIG_MANAGER_URL = "sortSourceConfig.managerUrl";
+
+    private static ManagerAddrGetHandler instance;
+
+    public Context context;
+
+    /**
+     * Delete no argument constructor.
+     */
+    private ManagerAddrGetHandler() {
+
+    }
+
+    /**
+     * Get URL where SortSdk request SortSourceConfig.
+     *
+     * @return URL to get SortSourceConfig.
+     */
+    public static String getSortSourceConfigUrl() {
+        String url = get().context.getString(KEY_SORT_SOURCE_CONFIG_MANAGER_URL);
+        if (StringUtils.isBlank(url)) {
+            LOG.error("Get SortSourceConfigUrl from CommonPropertiesHolder failed, "
+                    + "please check if there is any property of key {}.", KEY_SORT_SOURCE_CONFIG_MANAGER_URL);
+        }
+        return url;
+    }
+
+    /**
+     * Get URL where Sort-Standalone request SortClusterConfig.
+     *
+     * @return URL to get SortClusterConfig.
+     */
+    public static String getSortClusterConfigUrl() {
+        String url = get().context.getString(KEY_SORT_CLUSTER_CONFIG_MANAGER_URL);

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] dockerzhang merged pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org