You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/18 13:04:38 UTC

[GitHub] [apisix-website] 1502shivam-singh opened a new pull request #346: style: set max-width of doc container to avoid x-overflow

1502shivam-singh opened a new pull request #346:
URL: https://github.com/apache/apisix-website/pull/346


   Fixes: #288
   
   Changes:
   
   Previously (See the x-scroll bar due to overflow in document main container (.docMainContainer))
   
   ![image](https://user-images.githubusercontent.com/57267960/118654712-765c3100-b806-11eb-91b9-9ca1aa73a51b.png)
   
   Screenshots of the change:
   
   Later (After setting max-width of container)
   
   ![image](https://user-images.githubusercontent.com/57267960/118655382-203bbd80-b807-11eb-80cf-fd8d9fdb7740.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy preview for *apisix* ready!
   
   Built with commit b4bb7d170bb97938e16d37c83f4d65f79d29491a
   
   https://deploy-preview-346--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843521728


   @1502shivam-singh maybe you need to rebase the branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-844532138


   > I did the rebase, check if it's fine now.
   
   try rebase master and it would need force push. there are still 10 commits right now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-844714809


   > I did the rebase, check if it's fine now.
   
   https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
   check the rebase part, i have also learned it from there only


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-845128081






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy preview for *apisix* processing.
   
   Building with commit b4bb7d170bb97938e16d37c83f4d65f79d29491a
   
   https://app.netlify.com/sites/apisix/deploys/60a3bb604b5a2f0008a2fd5e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy Preview for *apisix* ready!
   
   Built with commit 5b68e3ec14fa27958e2beac4a28481c31dd2bc68
   
   https://deploy-preview-346--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-845128081


   No bro, clean you history, see the active changes 3700+ active changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-844995251


   > Hi @Yiyiyimu, maybe it's ok to merge? because this PR only contain the current changes, and we will use Squash to merge.
   
   I guess I should try for sometime. Been a little rusty with git, so need to check out something and then try.
   
   Thanks @iamayushdas  will check the link you shared.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy Preview for *apisix* ready!
   
   Built with commit 7a5d928fa155bf1f449884c0a84e359fc2e027dc
   
   https://deploy-preview-346--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-844517399


   I did the rebase, check if it's fine now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-844620487


   Hi @Yiyiyimu, maybe it's ok to merge? because this PR only contain the current changes, and we will use Squash to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy Preview for *apisix* processing.
   
   Building with commit 7a5d928fa155bf1f449884c0a84e359fc2e027dc
   
   https://app.netlify.com/sites/apisix/deploys/60a66335e89abd0007a80a83


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843588988


   > @1502shivam-singh maybe you need to rebase the branch
   
   Hmmm, feel you. Too much backlog here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-845124653


   Squashed the commits, have a look guys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy Preview for *apisix* processing.
   
   Building with commit 5b68e3ec14fa27958e2beac4a28481c31dd2bc68
   
   https://app.netlify.com/sites/apisix/deploys/60a662838228e0000783b965


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh closed pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
1502shivam-singh closed pull request #346:
URL: https://github.com/apache/apisix-website/pull/346


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #346: style: set max-width of doc container to avoid x-overflow

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #346:
URL: https://github.com/apache/apisix-website/pull/346#issuecomment-843153385


   Deploy Preview for *apisix* processing.
   
   Building with commit 17d2f6cae8bb2978b3abc4494c4415a887fc261c
   
   https://app.netlify.com/sites/apisix/deploys/60a58514953b500008c9fb14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org