You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/16 10:19:56 UTC
[GitHub] [lucene] rmuir opened a new pull request #686: LUCENE-10421: use Constant instead of relying upon timestamp
rmuir opened a new pull request #686:
URL: https://github.com/apache/lucene/pull/686
All the other uses of `System.currentTimeMillis` (both java and test code) are no good, but i'd rather tackle them in a followup issue (I will make a JIRA). Eventually, we can ban use of wall clock time with forbidden-apis.
But for now, I'd just like to have nightly benchmarks again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on pull request #686: LUCENE-10421: use Constant instead of relying upon timestamp
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #686:
URL: https://github.com/apache/lucene/pull/686#issuecomment-1050175765
Thanks @rmuir ! Are you okay to merge this? I got confused recently over a sometimes-reproducible test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #686: LUCENE-10421: use Constant instead of relying upon timestamp
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #686:
URL: https://github.com/apache/lucene/pull/686#issuecomment-1048810781
Hard not to think of [this XKCD](https://xkcd.com/221/). :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #686: LUCENE-10421: use Constant instead of relying upon timestamp
Posted by GitBox <gi...@apache.org>.
rmuir merged pull request #686:
URL: https://github.com/apache/lucene/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org