You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/11/19 00:02:59 UTC
[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request
#616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern
ChinmaySKulkarni commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern
URL: https://github.com/apache/phoenix/pull/616#discussion_r347670237
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
##########
@@ -57,181 +56,236 @@
private static final LiteralExpression[] NULL_EXPRESSIONS = new LiteralExpression[Determinism.values().length];
private static final LiteralExpression[] TYPED_NULL_EXPRESSIONS = new LiteralExpression[PDataType.values().length * Determinism.values().length];
private static final LiteralExpression[] BOOLEAN_EXPRESSIONS = new LiteralExpression[2 * Determinism.values().length];
-
+
static {
for (Determinism determinism : Determinism.values()) {
- NULL_EXPRESSIONS[determinism.ordinal()] = new LiteralExpression(null, determinism);
+ NULL_EXPRESSIONS[determinism.ordinal()] = new LiteralExpression(null, null,
Review comment:
Can we not convert this into a builder too, or is this left out since there is some issue due to the static block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services