[jira] Issue Comment Edited: (WICKET-2696) PATCH: TabbedPanel should allow modifying i) tab panel id and ii) tab panel parent component.

["Martin Makundi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804085#action_12804085 ] 

Martin Makundi edited comment on WICKET-2696 at 1/23/10 2:17 PM:
-----------------------------------------------------------------

I will try to clarifty rationale behind the proposal:

a) it does not (hopefully) break anything

b) gives more flexibility to where the child panels are rendered. 

We have the following markup use case which required such a change:

<div id="container">

<div id="navigation-area">

<div id="master-tabs">
   <wicket:container wicket:id="tabs" .../> <!-- 1st set of TabbedPanel -->
</div> <!-- master-tabs -->

<div id="nested-tabs">
   <wicket:container wicket:id="panel"/> <!-- 2nd set of TabbedPanel will be rendered here -->
</div> <!-- master-tabs -->

</div> <!-- navigation-area -->

<div id="content-area" wicket:id="sub-panel">  
   <!-- finally, the panel selected from 2nd (nested) tabbed panel should be rendered here. -->
</div> <!-- content-area -->

</div> <!-- container -->


If markup layout is not to be broken, TabbedPanel2 must be able to addOrReplace the panel onto TabbedPanel1's childrens' level.




      was (Author: mmakundi):
    I will try to clarifty rationale behind the proposal:

a) it does not (hopefully) break anything

b) gives more flexibility to where the child panels are rendered. 

We have the following markup use which required such a change:

<div id="container">

<div id="navigation-area">

<div id="master-tabs">
   <wicket:container wicket:id="tabs" .../> <!-- 1st set of TabbedPanel -->
</div> <!-- master-tabs -->

<div id="nested-tabs">
   <wicket:container wicket:id="panel"/> <!-- 2nd set of TabbedPanel will be rendered here -->
</div> <!-- master-tabs -->

</div> <!-- navigation-area -->

<div id="content-area" wicket:id="sub-panel">  
   <!-- finally, the panel selected from 2nd (nested) tabbed panel should be rendered here. -->
</div> <!-- content-area -->

</div> <!-- container -->


If markup layout is not to be broken, TabbedPanel2 must be able to addOrReplace the panel onto TabbedPanel1's childrens' level.



  
> PATCH: TabbedPanel should allow modifying i) tab panel id and ii) tab panel parent component.
> ---------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2696
>                 URL: https://issues.apache.org/jira/browse/WICKET-2696
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC7
>            Reporter: Martin Makundi
>            Priority: Minor
>         Attachments: tabpanel-patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> TabbedPanel should allow modifying i) tab panel id and ii) tab panel parent component.
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.