You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zhengchenyu (via GitHub)" <gi...@apache.org> on 2025/03/11 12:48:29 UTC
[PR] [#2389] fix:(remote merge): Fixed the issue of losing data when calling hasNext multiple times. [uniffle]
zhengchenyu opened a new pull request, #2390:
URL: https://github.com/apache/uniffle/pull/2390
### What changes were proposed in this pull request?
KeyValueReader::next combines the semantics of hasNext and next, which is unreasonable and should be separated.
### Why are the changes needed?
Fix: #2389
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test and integration test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2389] fix:(remote merge): Fixed the issue of losing data when calling hasNext multiple times. [uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2390:
URL: https://github.com/apache/uniffle/pull/2390#issuecomment-2714185616
## Test Results
2 986 files - 10 2 986 suites - 10 6h 27m 3s ⏱️ - 5m 4s
1 105 tests ± 0 1 102 ✅ - 1 2 💤 ±0 0 ❌ ±0 1 🔥 +1
13 839 runs - 10 13 808 ✅ - 11 30 💤 ±0 0 ❌ ±0 1 🔥 +1
For more details on these errors, see [this check](https://github.com/apache/uniffle/runs/38563407603).
Results for commit 6eab309b. ± Comparison against base commit 86da646b.
[test-results]:data:application/gzip;base64,H4sIANo20GcC/02MSQ7DIAwAvxJx7sFgBUE/UxEWCTUJFcup6t8LSUM5+DBje97E+dUmcp+YFPw2kVR8HtmUqLIPezPIGFZV97ldUArzhY9UtD4d+7unf7W/LpzyaxXQhY0xxPZWTSz7UUWB8oe9igJEd2cV4RJD9eAxqsO2+VyBcKsWBLkYbp0WVteRiwSpDXBwytCZWlDckc8XWqKrdBQBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2389] fix:(remote merge): Fixed the issue of losing data when calling hasNext multiple times. [uniffle]
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu merged PR #2390:
URL: https://github.com/apache/uniffle/pull/2390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org