[GitHub] zookeeper pull request #92: ZOOKEEPER-2080: Fix deadlock in dynamic reconfig...

[eribeiro <gi...@git.apache.org>]

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/92#discussion_r96929565
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -434,6 +434,10 @@ public int getQuorumSize(){
         //last proposed quorum verifier
         public QuorumVerifier lastSeenQuorumVerifier = null;
     
    +    // Lock object that guard access to quorumVerifier and lastSeenQuorumVerifier.
    +    private byte[] qvLock = new byte[0];
    --- End diff --
    
    It should be *final* if you want to use it as a lock object. Also, as constant it would be renamed as *QV_LOCK*.
    
    nit: Also, we usually use a `Object`:
    ```
    private final Object LOCK = new Object();
    ```
    or a `ReentrantReadWriteLock` (more verbose tough, with try-finally, etc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---