[jira] Closed: (OFBIZ-1225) Added a few missing UiLabels to order component

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1225.
----------------------------------

    Resolution: Fixed

Thanks Bilgin,

Your patch is in trunk rev.  574072  

Actually I did some more work :
I suppressed all instances and references to AccountingNoPaymentMethodsOnFile. I could have done more works like this. For instance why adding AccountingEditCreditCard=Edit Credit Card in PartyUiLabels.properties and not in AccountingUiLabels.properties. I' see that there are already some labels like AccountingCreditCard=Credit Card in this file. But I guess the main reason they were not moved to AccountingUiLabels.properties is because there are also other languages involved. And even if it's only more simple work to do, nobody is really interested (tedious and a bit risky ;o). In case of new labels we should avoid putting them in  wrong modules.

Also I kept OrderPurchaseOrderNumber in place of OrderPONumber, was not sure it was better, did you that intentionaly ?

> Added a few missing UiLabels  to order component
> ------------------------------------------------
>
>                 Key: OFBIZ-1225
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1225
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ui.patch, ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied  from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.