svn commit: r1902421 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandler.java

[le...@apache.org]

Author: lehmi
Date: Sun Jul  3 08:13:12 2022
New Revision: 1902421

URL: http://svn.apache.org/viewvc?rev=1902421&view=rev
Log:
PDFBOX-4836: omit intermediate ByteArrayStream

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandler.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandler.java?rev=1902421&r1=1902420&r2=1902421&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandler.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandler.java Sun Jul  3 08:13:12 2022
@@ -531,9 +531,10 @@ public abstract class SecurityHandler<T_
             }
         }
         decryptDictionary(stream, objNum, genNum);
-        byte[] encrypted = IOUtils.toByteArray(stream.createRawInputStream());
-        ByteArrayInputStream encryptedStream = new ByteArrayInputStream(encrypted);
-        try (OutputStream output = stream.createRawOutputStream())
+        // the input and the output stream of a still encrypted COSStream aren't no longer based
+        // on the same object so that it is safe to omit the intermediate ByteArrayStream
+        try (InputStream encryptedStream = stream.createRawInputStream(); //
+                OutputStream output = stream.createRawOutputStream())
         {
             encryptData(objNum, genNum, encryptedStream, output, true /* decrypt */);
         }