You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2016/09/26 23:05:22 UTC
[1/2] hbase git commit: HBASE-16705 Eliminate long to Long auto
boxing in LongComparator. (binlijin)
Repository: hbase
Updated Branches:
refs/heads/0.98 6903296a3 -> 821871966
refs/heads/branch-1 67a43c305 -> a3485cc5a
HBASE-16705 Eliminate long to Long auto boxing in LongComparator. (binlijin)
Conflicts:
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a3485cc5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a3485cc5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a3485cc5
Branch: refs/heads/branch-1
Commit: a3485cc5ab42cf20f1edd53f1d235d2be3038a80
Parents: 67a43c3
Author: anoopsamjohn <an...@gmail.com>
Authored: Mon Sep 26 11:11:52 2016 +0530
Committer: Andrew Purtell <ap...@apache.org>
Committed: Mon Sep 26 15:41:45 2016 -0700
----------------------------------------------------------------------
.../hadoop/hbase/filter/LongComparator.java | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/a3485cc5/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
index 947c9da..57e63de 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
@@ -32,18 +32,18 @@ import org.apache.hadoop.hbase.util.Bytes;
@InterfaceAudience.Public
@InterfaceStability.Stable
public class LongComparator extends ByteArrayComparable {
- private Long longValue;
+ private long longValue;
- public LongComparator(long value) {
- super(Bytes.toBytes(value));
- this.longValue = value;
- }
+ public LongComparator(long value) {
+ super(Bytes.toBytes(value));
+ this.longValue = value;
+ }
- @Override
- public int compareTo(byte[] value, int offset, int length) {
- Long that = Bytes.toLong(value, offset, length);
- return this.longValue.compareTo(that);
- }
+ @Override
+ public int compareTo(byte[] value, int offset, int length) {
+ long that = Bytes.toLong(value, offset, length);
+ return Long.compare(longValue, that);
+ }
/**
* @return The comparator serialized using pb
[2/2] hbase git commit: HBASE-16705 Eliminate long to Long auto
boxing in LongComparator. (binlijin)
Posted by ap...@apache.org.
HBASE-16705 Eliminate long to Long auto boxing in LongComparator. (binlijin)
Conflicts:
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/82187196
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/82187196
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/82187196
Branch: refs/heads/0.98
Commit: 82187196686f7fda383e96bec91787b507c993a8
Parents: 6903296
Author: anoopsamjohn <an...@gmail.com>
Authored: Mon Sep 26 11:11:52 2016 +0530
Committer: Andrew Purtell <ap...@apache.org>
Committed: Mon Sep 26 15:42:07 2016 -0700
----------------------------------------------------------------------
.../hadoop/hbase/filter/LongComparator.java | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/82187196/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
index 5c8a3cb..3e96b01 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
@@ -32,18 +32,18 @@ import org.apache.hadoop.hbase.util.Bytes;
@InterfaceAudience.Public
@InterfaceStability.Stable
public class LongComparator extends ByteArrayComparable {
- private Long longValue;
+ private long longValue;
- public LongComparator(long value) {
- super(Bytes.toBytes(value));
- this.longValue = value;
- }
+ public LongComparator(long value) {
+ super(Bytes.toBytes(value));
+ this.longValue = value;
+ }
- @Override
- public int compareTo(byte[] value, int offset, int length) {
- Long that = Bytes.toLong(value, offset, length);
- return this.longValue.compareTo(that);
- }
+ @Override
+ public int compareTo(byte[] value, int offset, int length) {
+ long that = Bytes.toLong(value, offset, length);
+ return Long.compare(longValue, that);
+ }
/**
* @return The comparator serialized using pb