You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/14 06:31:04 UTC

[GitHub] [hudi] fengjian428 commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

fengjian428 commented on code in PR #6071:
URL: https://github.com/apache/hudi/pull/6071#discussion_r920796799


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java:
##########
@@ -108,6 +109,12 @@ public class HoodieLockConfig extends HoodieConfig {
       .sinceVersion("0.8.0")

Review Comment:
   > I have an idea, wdyt about setting the `metatable`'s subpath as the default path?
   
   yeah, I've thought about it too, if so, since we cannot get basePath from lock config, need to pass extra parameters into the constructor, and other lock providers also need to be refactored. What do you think, is it worth ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org