You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "utkarsharma2 (via GitHub)" <gi...@apache.org> on 2023/06/07 04:39:38 UTC
[GitHub] [airflow] utkarsharma2 opened a new pull request, #31751: SnowflakeSqlApiOperator - Change the base class
utkarsharma2 opened a new pull request, #31751:
URL: https://github.com/apache/airflow/pull/31751
Since `SnowflakeOperator` will be deprecated, changed `SnowflakeSqlApiOperator` base class to `SQLExecuteQueryOperator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #31751: SnowflakeSqlApiOperator - Change the base class
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #31751:
URL: https://github.com/apache/airflow/pull/31751#issuecomment-1585791947
>But if you strongly feel we should directly expose hook_params I'm happy to make that change :)
No strong opinion. We can leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31751: SnowflakeSqlApiOperator - Change the base class
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31751:
URL: https://github.com/apache/airflow/pull/31751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] utkarsharma2 commented on pull request #31751: SnowflakeSqlApiOperator - Change the base class
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #31751:
URL: https://github.com/apache/airflow/pull/31751#issuecomment-1585784170
@eladkal We can do that, but I think it's better in the current condition for two reasons IMO.
1. Interface is aligned with the interface of `SnowflakeOperator`, which I think users already are used to.
2. Exposing `hook_params` to users would require them to know what a hook is(just the terminology), which I think is not required if they want to use the operator. Also, a user who is just trying to connect to Snowflake would be more familiar with the warehouse/database so they should be exposed as is.
But if you strongly feel we should directly expose `hook_params` I'm happy to make that change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org