You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/11/16 15:47:26 UTC

[kudu-CR](gh-pages) [blog] Call for Posts 

Hello Mike Percy, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11941

to review the following change.


Change subject: [blog] Call for Posts
......................................................................

[blog] Call for Posts

This commit adds a call for guest posts as agreed on the latest virtual
meetup on Slack

Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
---
A _posts/2018-11-16-call-for-posts.md
1 file changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/11941/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11941

to look at the new patch set (#2).

Change subject: [blog] Call for Posts
......................................................................

[blog] Call for Posts

This commit adds a call for guest posts as agreed on the latest virtual
meetup on Slack

Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
---
A _posts/2018-11-16-call-for-posts.md
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/11941/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11941

to look at the new patch set (#5).

Change subject: [blog] Call for Posts
......................................................................

[blog] Call for Posts

This commit adds a call for guest posts as agreed on the latest virtual
meetup on Slack

Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
---
A _posts/2018-12-11-call-for-posts.md
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/11941/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 2: Code-Review+2

On second review, I think my prior feedback was excessively nitpicky, to feel free to submit as-is (although I'd advocate for the Oxford comma :D)


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 20 Nov 2018 23:52:15 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11941

to look at the new patch set (#4).

Change subject: [blog] Call for Posts
......................................................................

[blog] Call for Posts

This commit adds a call for guest posts as agreed on the latest virtual
meetup on Slack

Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
---
A _posts/2018-12-07-call-for-posts.md
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/11941/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 3: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 04 Dec 2018 20:31:03 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 2:

(2 comments)

looks great, some minor suggestions

http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md
File _posts/2018-11-16-call-for-posts.md:

http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md@9
PS2, Line 9: testing
nit: testing,


http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md@14
PS2, Line 14: showcase your project
tell the world about how you are using Kudu in your project



-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 20 Nov 2018 23:00:46 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11941

to look at the new patch set (#3).

Change subject: [blog] Call for Posts
......................................................................

[blog] Call for Posts

This commit adds a call for guest posts as agreed on the latest virtual
meetup on Slack

Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
---
A _posts/2018-11-30-call-for-posts.md
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/11941/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 17:14:39 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................

[blog] Call for Posts

This commit adds a call for guest posts as agreed on the latest virtual
meetup on Slack

Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Reviewed-on: http://gerrit.cloudera.org:8080/11941
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
A _posts/2018-12-11-call-for-posts.md
1 file changed, 21 insertions(+), 0 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 11 Dec 2018 19:41:10 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 2:

here's a rendering of the post: http://bukor.me/kudu/2018/11/16/call-for-posts.html

This should be merged only after https://gerrit.cloudera.org/c/11940/ is merged and the new docs have been generated and merged as this post refers to an anchor on the contributing page that doesn't yet exist.


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 16 Nov 2018 15:51:52 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 23:30:39 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 5: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 11 Dec 2018 21:10:31 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Call for Posts

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 )

Change subject: [blog] Call for Posts
......................................................................


Patch Set 3:

(2 comments)

> Patch Set 2: Code-Review+2
> 
> On second review, I think my prior feedback was excessively nitpicky, to feel free to submit as-is (although I'd advocate for the Oxford comma :D)

No, the feedback sounds good (and I agree with the Oxford comma, just missed it somehow :D). I had to re-date the post anyway

http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md
File _posts/2018-11-16-call-for-posts.md:

http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md@9
PS2, Line 9: 
> nit: testing,
Done


http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md@14
PS2, Line 14: 
> tell the world about how you are using Kudu in your project
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8
Gerrit-Change-Number: 11941
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 22:48:36 +0000
Gerrit-HasComments: Yes