You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "singhpk234 (via GitHub)" <gi...@apache.org> on 2025/10/11 00:05:57 UTC
[PR] FIX REG tests with cloud providers [polaris]
singhpk234 opened a new pull request, #2793:
URL: https://github.com/apache/polaris/pull/2793
Always start polaris with the `namespace-custom-location` to preserve the existing behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FIX REG tests with cloud providers [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on PR #2793:
URL: https://github.com/apache/polaris/pull/2793#issuecomment-3395675603
```
t_pyspark/src/test_spark_sql_s3_with_privileges.py ............... [100%]
=================================================== warnings summary ===================================================
t_pyspark/src/test_spark_sql_s3_with_privileges.py: 31 warnings
/Users/prsingh/Desktop/oss-work/polaris/client/python/polaris/catalog/api/iceberg_o_auth2_api.py:114: DeprecationWarning: POST /v1/oauth/tokens is deprecated.
warnings.warn("POST /v1/oauth/tokens is deprecated.", DeprecationWarning)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
===================================== 15 passed, 31 warnings in 205.43s (0:03:25) ======================================
Sun Oct 12 19:34:25 PDT 2025: Test SUCCEEDED: t_pyspark:test_spark_sql_s3_with_privileges.py
Sun Oct 12 19:34:25 PDT 2025: Tests completed with 1 successes and 0 failures
```
suite now passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FIX REG tests with cloud providers [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #2793:
URL: https://github.com/apache/polaris/pull/2793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FIX REG tests with cloud providers [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #2793:
URL: https://github.com/apache/polaris/pull/2793#discussion_r2423105463
##########
regtests/docker-compose.yml:
##########
@@ -38,6 +38,7 @@ services:
polaris.features."ALLOW_INSECURE_STORAGE_TYPES": "true"
polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES": "[\"FILE\",\"S3\",\"GCS\",\"AZURE\"]"
polaris.features."ALLOW_OVERLAPPING_CATALOG_URLS": "true"
+ polaris.config.namespace-custom-location.enabled: "true"
Review Comment:
I agree. It looks we are missing consistency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FIX REG tests with cloud providers [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on PR #2793:
URL: https://github.com/apache/polaris/pull/2793#issuecomment-3395367293
update the PR to match the patten of the other configs and also updated the doc for non-docker tests.
> did we verify if this fixes the test failure
unfortunately, no I don't have an AWS account handy with me, I am working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FIX REG tests with cloud providers [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2793:
URL: https://github.com/apache/polaris/pull/2793#discussion_r2422420024
##########
regtests/docker-compose.yml:
##########
@@ -38,6 +38,7 @@ services:
polaris.features."ALLOW_INSECURE_STORAGE_TYPES": "true"
polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES": "[\"FILE\",\"S3\",\"GCS\",\"AZURE\"]"
polaris.features."ALLOW_OVERLAPPING_CATALOG_URLS": "true"
+ polaris.config.namespace-custom-location.enabled: "true"
Review Comment:
this looks odd... other flags start with `polaris.features.` but this is `polaris.config.`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FIX REG tests with cloud providers [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #2793:
URL: https://github.com/apache/polaris/pull/2793#issuecomment-3393554332
Thanks for the fix, @singhpk234 ! LGTM, did we verify if this fixes the test failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org