You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/23 15:49:01 UTC
[jira] [Commented] (GEODE-4855) Cache::createPdxInstanceFactory
should return an object
[ https://issues.apache.org/jira/browse/GEODE-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448335#comment-16448335 ]
ASF subversion and git services commented on GEODE-4855:
--------------------------------------------------------
Commit 9aac902a6c4d138f19860e229553e7494e674330 in geode-native's branch refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=9aac902 ]
GEODE-4855: Refactor Cache::createPdxInstanceFactory to return value. (#283)
* Fixes C++ integration test.
* Fixes .NET integration test.
> Cache::createPdxInstanceFactory should return an object
> -------------------------------------------------------
>
> Key: GEODE-4855
> URL: https://issues.apache.org/jira/browse/GEODE-4855
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Assignee: Jacob S. Barrett
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently it returns a shared_ptr, when it's clearly not shared. No reason to be allocating memory here, let's just return an object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)