You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/08/08 17:19:19 UTC
Review Request 13433: Fixed a performance problem in Master::Http::stats().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13433/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
Master::Http::stats() has performance problem. After profiling (screenshot attached), we found the main cause is due to range addition (e.g. ports resources). Since we don't need to accumulate range resources anyway, I reorganized the code to avoid adding range resources.
Diffs
-----
src/master/http.cpp ca66d67
Diff: https://reviews.apache.org/r/13433/diff/
Testing
-------
make -j4 check
File Attachments
----------------
perf profiling results
https://reviews.apache.org/media/uploaded/files/2013/08/08/Screen_Shot_2013-08-07_at_3.59.34_PM.png
Thanks,
Jie Yu
Re: Review Request 13433: Fixed a performance problem in
Master::Http::stats().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13433/#review24891
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Aug. 8, 2013, 3:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13433/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 3:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master::Http::stats() has performance problem. After profiling (screenshot attached), we found the main cause is due to range addition (e.g. ports resources). Since we don't need to accumulate range resources anyway, I reorganized the code to avoid adding range resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp ca66d67
>
> Diff: https://reviews.apache.org/r/13433/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> File Attachments
> ----------------
>
> perf profiling results
> https://reviews.apache.org/media/uploaded/files/2013/08/08/Screen_Shot_2013-08-07_at_3.59.34_PM.png
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 13433: Fixed a performance problem in
Master::Http::stats().
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13433/#review24888
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 8, 2013, 3:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13433/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 3:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master::Http::stats() has performance problem. After profiling (screenshot attached), we found the main cause is due to range addition (e.g. ports resources). Since we don't need to accumulate range resources anyway, I reorganized the code to avoid adding range resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp ca66d67
>
> Diff: https://reviews.apache.org/r/13433/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> File Attachments
> ----------------
>
> perf profiling results
> https://reviews.apache.org/media/uploaded/files/2013/08/08/Screen_Shot_2013-08-07_at_3.59.34_PM.png
>
>
> Thanks,
>
> Jie Yu
>
>