You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by ottobackwards <gi...@git.apache.org> on 2017/12/19 22:25:45 UTC
[GitHub] metron pull request #877: METRON-1376 metron-rc-check script should have nam...
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/877
METRON-1376 metron-rc-check script should have named params
This PR adds named parameter support to the metron-rc-check script
```bash
-> % bash ./metron-rc-check -h
usage: ./metron-rc-check
-v/--version=<version> The version of the metron release. [Required]
-c/--candidate=<RC#> Defines the Release Candidate. [Required]
-b/--bro=<bro version> The version of the bro kafka plugin. [Required]
-h/--help Usage information.
example:
metron-rc-check --version=0.4.2 --canidate=RC2 --bro=0.1.0
```
test with the line above or variations there of.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron rc-params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/877.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #877
----
commit ea71b91ad4cbf3bbaa411d2d80def367e4d2efc1
Author: Otto Fowler <ot...@...>
Date: 2017-12-19T21:17:07Z
add named params
----
---
[GitHub] metron pull request #877: METRON-1376 metron-rc-check script should have nam...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/877
---
[GitHub] metron issue #877: METRON-1376 metron-rc-check script should have named para...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/877
@nickwallen
---
[GitHub] metron issue #877: METRON-1376 metron-rc-check script should have named para...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/877
+1 Works great, @ottobackwards !
---