You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/01 17:08:35 UTC
[GitHub] [dubbo-go] cjphaha opened a new pull request #1035: add read configuration from the command line when start
cjphaha opened a new pull request #1035:
URL: https://github.com/apache/dubbo-go/pull/1035
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Add feature :
Developers can add command line parameters when starting the program to set the location of log, provider, consumer and router configuration files.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
In https://github.com/dubbogo/dubbo-samples/dubbo-samples/golang/helloworld/dubbo/go-server/app
You can start server like this:
```shell
go run . -proConf ../profiles/dev/server.yml -logConf ../profiles/dev/log.yml
```
In https://github.com/dubbogo/dubbo-samples/dubbo-samples/golang/helloworld/dubbo/go-client/app
You can start client like this:
```shell
go run . -conConf ../profiles/dev/client.yml -logConf ../profiles/dev/log.yml
```
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha commented on pull request #1035: add read configuration from the command line when start
Posted by GitBox <gi...@apache.org>.
cjphaha commented on pull request #1035:
URL: https://github.com/apache/dubbo-go/pull/1035#issuecomment-771447571
> I think we should support env parameter to config that we did before too. This change will be
> backward compatible.
Yes, this is my problem. I didn’t think it completely. I will revise it later, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1035: add read configuration from the command line when start
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1035:
URL: https://github.com/apache/dubbo-go/pull/1035#issuecomment-772160904
Pls change the target branch from develop to 1.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha commented on pull request #1035: add read configuration from the command line when start
Posted by GitBox <gi...@apache.org>.
cjphaha commented on pull request #1035:
URL: https://github.com/apache/dubbo-go/pull/1035#issuecomment-771447571
> I think we should support env parameter to config that we did before too. This change will be
> backward compatible.
Yes, this is my problem. I didn’t think it completely. I will revise it later, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha closed pull request #1035: add read configuration from the command line when start
Posted by GitBox <gi...@apache.org>.
cjphaha closed pull request #1035:
URL: https://github.com/apache/dubbo-go/pull/1035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org