[GitHub] [daffodil] tuxji commented on a change in pull request #618: dfdl prefix properties on dfdl annotation elements should generate us…

[GitBox <gi...@apache.org>]

tuxji commented on a change in pull request #618:
URL: https://github.com/apache/daffodil/pull/618#discussion_r677681641



##########
File path: .sbtopts
##########
@@ -12,5 +12,8 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-
--mem 4096
+#-mem 4096
+-J-Xms4096m
+-J-Xmx4096m
+-J-Xss4M
+-J-XX:ReservedCodeCacheSize=512m

Review comment:
       You don't need to include this changed file since the same change was already merged in another pull request today.

##########
File path: daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestDefError.scala
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.daffodil.section00.general
+
+import org.apache.daffodil.tdml.Runner
+import org.junit.{AfterClass, Test}
+
+object TestDefError {
+
+  val testDir = "/org/apache/daffodil/section00/general/"
+  val runner = Runner(testDir, "generalSchedmaDefinitionError.tdml",validateTDMLFile = false)
+
+  @AfterClass def tearDown(): Unit = {
+    runner.reset
+  }
+
+}
+
+class TestDefError {
+
+  import TestDefError._
+  @Test def test_schema_definition_err(): Unit = { runner.runOneTest("schema_definition_err") }

Review comment:
       When you change the test name in the tdml file, you'll need to change it here as well.

##########
File path: daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestDefError.scala
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.daffodil.section00.general
+
+import org.apache.daffodil.tdml.Runner
+import org.junit.{AfterClass, Test}
+
+object TestDefError {
+
+  val testDir = "/org/apache/daffodil/section00/general/"
+  val runner = Runner(testDir, "generalSchedmaDefinitionError.tdml",validateTDMLFile = false)

Review comment:
       In addition to changing the test name as Steve suggested, I suggest also changing the scala and tdml names.  I'm fine with a shorter name than "dfdl_format_prefixed_attributes_sde" or a camel case name, just make the name more descriptive/specific.  Please also pay attention to Scala's [style guide](https://docs.scala-lang.org/style/), e.g., each comma in the above line should have a space character after it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org