You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/04/04 13:04:35 UTC

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #111: try to release memory asap in ReadOnlyMemChunk

MyXOF commented on a change in pull request #111: try to release memory asap in ReadOnlyMemChunk
URL: https://github.com/apache/incubator-iotdb/pull/111#discussion_r272167702
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/engine/querycontext/ReadOnlyMemChunk.java
 ##########
 @@ -89,6 +89,8 @@ private void init() {
           break;
       }
     }
+    //release memory
+    memSeries = null;
 
 Review comment:
   Would this cause resource leak? It is better to have something like 
   `
   memSeries.release()
   memSeries = null
   `
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services