You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by sr...@apache.org on 2010/06/16 23:38:34 UTC

svn commit: r955405 - /mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java

Author: srowen
Date: Wed Jun 16 21:38:34 2010
New Revision: 955405

URL: http://svn.apache.org/viewvc?rev=955405&view=rev
Log:
Fix handling of default-value args

Modified:
    mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java?rev=955405&r1=955404&r2=955405&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java Wed Jun 16 21:38:34 2010
@@ -326,12 +326,10 @@ public abstract class AbstractJob extend
   
   protected static void maybePut(Map<String,String> args, CommandLine cmdLine, Option... opt) {
     for (Option o : opt) {
-      if (cmdLine.hasOption(o)) {
-        // nulls are ok, for cases where options are simple flags.
-        Object vo = cmdLine.getValue(o);
-        String value = (vo == null) ? null : vo.toString();
-        args.put(o.getPreferredName(), value);
-      }
+      // nulls are ok, for cases where options are simple flags.
+      Object vo = cmdLine.getValue(o);
+      String value = (vo == null) ? null : vo.toString();
+      args.put(o.getPreferredName(), value);
     }
   }